Skip to content

fix: carry providerKind through IPC JSON instead of matching user copy - #163

Merged
KazeKaze93 merged 1 commit into
masterfrom
chore/provider-error-kind-not-text-based
Aug 13, 2026
Merged

fix: carry providerKind through IPC JSON instead of matching user copy#163
KazeKaze93 merged 1 commit into
masterfrom
chore/provider-error-kind-not-text-based

Conversation

@KazeKaze93

Copy link
Copy Markdown
Owner

Summary

  • throwProviderSearchIpcError JSON-encodes the full ProviderSearchErrorPayload (including providerKind) into Error.message, so kind survives Electron invoke which drops custom Error fields.
  • Renderer parse no longer infers kind by matching PROVIDER_SEARCH_USER_MESSAGES text. User copy is provider-agnostic (no hardcoded Rule34).
  • BrowseErrorState kind values and use sites unchanged.

Test plan

  • Gelbooru network error — BrowseErrorState icon/text, no Rule34
  • Rule34 network error — no regression
  • Rate limit on both providers — kind still rate_limit
  • npm run typecheck / lint / test — already green (46 files / 314 tests)

@KazeKaze93
KazeKaze93 merged commit 4de7448 into master Aug 13, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant