Skip to content

fix: viewer hasNextPage predicate off-by-boundary (Playlist/Artist) - #162

Merged
KazeKaze93 merged 1 commit into
masterfrom
fix/viewer-hasnextpage-predicate-off-by-boundary
Aug 13, 2026
Merged

fix: viewer hasNextPage predicate off-by-boundary (Playlist/Artist)#162
KazeKaze93 merged 1 commit into
masterfrom
fix/viewer-hasnextpage-predicate-off-by-boundary

Conversation

@KazeKaze93

Copy link
Copy Markdown
Owner

Summary

  • Playlist/Artist openViewer now pass the react-query hasNextPage flag instead of a loaded-count vs page-size / totalCount predicate. A full last page (50/50) no longer freezes the viewer next-arrow while more data exists.
  • Browse already passed the query flag; unchanged. Background gallery fetch without appendQueueIds (P3) is out of scope.
  • Source-scan regression test locks all five galleries to hasNextPage: hasNextPage.

Test plan

  • Playlist with >50 posts: open viewer on last card of the first loaded page (exactly 50), press next — page 2 loads, navigation continues
  • Artist with >50 posts: same first-page boundary; next continues (and totalGlobalCount still stops when loaded count is exhausted)
  • Playlist/Artist last page not a multiple of 50 — no regression
  • Exhausted data (short last page, query hasNextPage === false) — next-arrow stops
  • npm run typecheck / lint / test — already green on the branch (46 files / 312 tests)

…ge-size comparison vs real react-query flag)
@KazeKaze93
KazeKaze93 merged commit d04e4cc into master Aug 13, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant