Issue 342/enable horizontal scrolling#419
Open
sergio-sastre wants to merge 3 commits intoKasperskyLab:masterfrom
Open
Issue 342/enable horizontal scrolling#419sergio-sastre wants to merge 3 commits intoKasperskyLab:masterfrom
sergio-sastre wants to merge 3 commits intoKasperskyLab:masterfrom
Conversation
…rst scrollable in the hierarchy
sergio-sastre
requested review from
AzamatCherchesov,
Nikitae57,
RuslanMingaliev,
eakurnikov and
matzuk
as code owners
sergio-sastre
commented
Nov 13, 2022
| step("Click nnHbutton5 in 3LevelNestedScrollView, middle item") { | ||
| NestedScrollViewsScreen { | ||
| nnHscrollView.scrollToView(nnHbutton5) | ||
| nnHbutton5.click() |
Contributor
Author
There was a problem hiding this comment.
by implementing point 2 #342 (comment), nnHscrollView.scrollToView(nnHbutton5) would not be needed since it would be done by the autoscroll.
Same for the other horizontalScrollView#scrollToView() calls in other tests of this class
Collaborator
|
@sergio-sastre any updates?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is point 1 from
#342 (comment)
Second point would be an improvement over point one, to be done in a different PR. Therefore, this could be merged without completing point 2.
Unfortunately, not sure when I'll find time for it