Conversation
|
Vladislav Sumin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
VladislavSumin
requested review from
AzamatCherchesov,
Nikitae57,
RuslanMingaliev,
eakurnikov and
matzuk
as code owners
| logger.d("The created adbCommand=$adbCommand") | ||
| cmdCommandPerformer.perform(adbCommand) | ||
| val adbCommand = "${ adbServerPort?.let { "-P $adbServerPort " } ?: "" }-s $deviceName ${command.body}" | ||
| logger.d("The created adbCommand=adb $adbCommand") |
There was a problem hiding this comment.
Would be cool to print out actual adb path since it's configurable. Otherwise it may mislead someone during adb related issues debugging
There was a problem hiding this comment.
this good idea. I'm add print adb path to log at server startup.
| private var isRunning = AtomicBoolean(false) | ||
|
|
||
| fun startDevicesObserving() { | ||
| fun startDevicesObservingSync() { |
There was a problem hiding this comment.
nit: I would just mention that this method is blocking in documentation as you did in AdbCommandPerformer::perform. I think blocking behavior is an expected one. Another hint is that there's startDevicesObservingAsync
There was a problem hiding this comment.
yes, I'm add documentation to this methods
| implementation(libs.kotlinStdlib) | ||
| implementation(libs.appcompat) | ||
| implementation(projects.adbServer.adbserverDevice) | ||
| implementation("com.kaspersky.android-components:adbserver-device") |
There was a problem hiding this comment.
nit: would be cool to use toml
There was a problem hiding this comment.
toml require to set version, yes in this case we can set any version, but i thing current way is more clear in this situation
| dependencies { | ||
| classpath(libs.kotlinPlugin) | ||
| classpath(libs.androidPlugin) | ||
| classpath("com.kaspersky.kaspresso:kaspresso-plugin") |
There was a problem hiding this comment.
nit: would be cool to use toml
|
|
||
| androidTestImplementation(projects.kaspresso) | ||
| androidTestImplementation(projects.allureSupport) | ||
| androidTestImplementation("com.kaspersky.android-components:kaspresso") |
There was a problem hiding this comment.
nit: would be cool to use toml
|
|
||
| androidTestImplementation(projects.kaspresso) | ||
| androidTestImplementation(projects.composeSupport) | ||
| androidTestImplementation("com.kaspersky.android-components:kaspresso") |
There was a problem hiding this comment.
nit: would be cool to use toml
…tachedDevicesByAdb function call
| /** | ||
| * @param adbPath - path to adb binary | ||
| */ | ||
| class AdbCommandPerformer( |
There was a problem hiding this comment.
| class AdbCommandPerformer( | |
| class AdbCommandExecutor( |
There was a problem hiding this comment.
Oh, I found CmdCommandPerformer exists already
| group = "com.kaspersky.kaspresso" | ||
| gradlePlugin { | ||
| plugins { | ||
| create("SignerPlugin") { |
There was a problem hiding this comment.
Not a SignerPlugin
| } | ||
|
|
||
| private val devices: MutableCollection<DeviceMirror> = mutableListOf() | ||
| private var isRunning = AtomicBoolean(false) |
There was a problem hiding this comment.
Is it accessed from multiple threads?
5 participants
Add Kaspresso plugin to implement issue #247
What changed:
enableFeaturePreviewfor features that enabled by defaultcompose-support&&allure-supportto satisfy gradle conventionsOut of scope for current pr: