[WIP] Describing assertion failures#19
Draft
eakurnikov wants to merge 3 commits intoKasperskyLab:masterfrom
eakurnikov:failure_logging
Draft
[WIP] Describing assertion failures#19eakurnikov wants to merge 3 commits intoKasperskyLab:masterfrom eakurnikov:failure_logging
eakurnikov wants to merge 3 commits intoKasperskyLab:masterfrom
eakurnikov:failure_logging
Conversation
eakurnikov
changed the title
dsvoronin
reviewed
Oct 1, 2019
Contributor
dsvoronin
left a comment
dsvoronin
left a comment
There was a problem hiding this comment.
Кажется что единственный способ не городить такие костыли: переделать то как составляет ошибку espresso, сами билдеры performException и всякие HumanReadables
| */ | ||
| internal fun ViewAssertion?.describe(): String { | ||
| if (this == null) return "null" | ||
| this ?: return "null" |
Contributor
There was a problem hiding this comment.
я не знаю code style, но контрол флоу читается оч плохо когда ретурны не в начале строки, так что я скорее за прошлую конструкцию, еще и с фигурными скобками
matzuk
reviewed
Oct 3, 2019
kaspresso/src/main/kotlin/com/kaspersky/kaspresso/failure/FailureLoggingProviderImpl.kt
Show resolved
Hide resolved
matzuk
reviewed
Nov 6, 2019
| } else { | ||
| viewMatcherDescribers[cachedViewMatcher!!.javaClass] | ||
| ?.invoke() | ||
| ?.apply { interaction.perform(this) } |
Member
There was a problem hiding this comment.
лишних вызовов interaction.perform не происходит?
|
|
RuslanMingaliev
changed the title
Collaborator
|
@eakurnikov any updates on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.