Update python_pathfinder.py - #3
Open
Zynx64 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to remove comments but i've reduced some code and made functions more direct so it loads faster.
Instead of using a nested loop to find the start and end points in the find_start_and_end function,
I just used enumerate to directly get the indices of the start and end points.
You can use a set to track visited cells instead of a 2D array.
Checking for membership in a set is faster than accessing a 2D array.
Checking memory in python - it quickly fill memory usage when larger mazes are used on low RAM devices (2< GB)
So that concludes why the above changes were made (mainly for efficiency and code compilation)