fix(jsx): cancel in-flight requests and prevent memory leaks in useAsync - #3732
fix(jsx): cancel in-flight requests and prevent memory leaks in useAsync#3732Unnati1007 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 19 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@Karanjot786 Please review the PR, do lemme know if any changes needed and merge it under GSSoC'26 |
|
Blocking — cancellation is faked. hooks.ts:769-792 only adds a stale-response version guard; there is no AbortController/AbortSignal, and asyncFn never receives a signal to pass to fetch, so the request runs to completion — same pattern as #2543. Thread a real AbortSignal into asyncFn. |
Description
This PR fixes memory leaks and race conditions inside the
useAsynchook under@termuijs/jsx. An active cleanup step was added to theuseEffectblock to discard in-flight state updates when dependencies change or when the component unmounts. In addition, theuseCallbackdependency array was emptied to keep therefetchfunction identity stable.Related Issue
Closes #3731
Which package(s)?
@termuijs/jsx
Type of Change
type:bug)type:feature)type:docs)type:testing)type:refactor)type:design)type:accessibility)type:performance)type:devops)type:security)Checklist
needs-starcheck blocks your merge otherwise.bun vitest runbun run buildbun run typecheckCONTRIBUTING.md.type: short description.markDirty()(if your change affects rendering).anytypes without an inline comment explaining why.GSSoC 2026 Participation
https://gssoc.girlscript.org/profile/Unnati1007Screenshots / Recordings (UI changes)
N/A (This is a non-visual background hooks lifecycle fix).
Notes for the Reviewer
useEffect's return function to avoid updating state on a destroyed fiber.refetchidentity across renders.