Skip to content

fix: resolve 4 bugs in termui #3595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saurabhhhcodes wants to merge 1 commit into from
Closed

fix: resolve 4 bugs in termui #3595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/forms-and-validation/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ class FormsExampleApp extends Widget {
return false; // Quit
}

if (event.key === 'c' && event.ctrl === false) {
if (event.key === 'c' && event.ctrl !) {

@coderabbitai coderabbitai Bot Aug 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Files:"
git ls-files | rg 'examples/forms-and-validation/src/index\.tsx$' || true

echo
echo "Relevant lines:"
sed -n '105,135p' examples/forms-and-validation/src/index.tsx | cat -n

echo
echo "Package/version hints:"
if [ -f package.json ]; then jq -r '.devDependencies.typescript // .dependencies.typescript // empty' package.json; fi
if [ -f examples/forms-and-validation/package.json ]; then jq -r '.devDependencies.typescript // .dependencies.typescript // empty' examples/forms-and-validation/package.json; fi

echo
echo "Search nearby key handler:"
rg -n "event\.key|quit|modal|ctrl" examples/forms-and-validation/src/index.tsx

Repository: Karanjot786/TermUI

Length of output: 2818

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Package manager files:"
git ls-files | rg '(^|/)package-lock\.json$|(^|/)pnpm-lock\.yaml$|(^|/)yarn\.lock$|(^|/)bun\.lockb?$|(^|/)tsconfig\.json$' || true

echo
echo "TypeScript parser availability:"
node - <<'JS'
const path = require.resolve('typescript');
const ts = require(path);
console.log('typescript path:', path);
console.log('typescript version:', ts.version);
const source = 'x.key === "c" && event.ctrl !;';
console.log(source);
const sf = ts.createSourceFile('a.ts', source, ts.ScriptTarget.Latest, true);
sf.forEachChild((n) => console.log(n.kind, ts.SyntaxKind[n.kind], n.getText().trim()));
console.log('parsed successfully');
JS

Repository: Karanjot786/TermUI

Length of output: 2505

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Bun lock TypeScript entry:"
rg -n "typescript|tsx" bun.lock | head -40

echo
echo "Root/package example tsconfigs:"
for f in package.json examples/forms-and-validation/tsconfig.json; do
  echo "--- $f"
  sed -n '1,220p' "$f"
done

Repository: Karanjot786/TermUI

Length of output: 3263

Negate event.ctrl instead of asserting it non-null.

event.ctrl ! is a non-null assertion and does not test for the Control key. Use !event.ctrl so plain c can open the modal and Ctrl+C can keep using the quit path.

Proposed fix 
-        if (event.key === 'c' && event.ctrl !) {
+        if (event.key === 'c' && !event.ctrl) {
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if (event.key === 'c' && event.ctrl !) {
if (event.key === 'c' && !event.ctrl) {
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@examples/forms-and-validation/src/index.tsx` at line 125, Update the keyboard
condition in the event handler to negate event.ctrl with !event.ctrl rather than
using a non-null assertion, so plain “c” opens the modal while Ctrl+C follows
the existing quit path.

Source: Coding guidelines

this.modal.show();
return true;
}
Expand Down
2 changes: 1 addition & 1 deletion examples/pomodoro-timer/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ class GradientProgressBar extends Widget {

const attrs = styleToCellAttrs(this._style);

const label = this._showLabel ? ` ${Math.round(this._value * 100)}%` : '';
const label = this._showLabel ? ` ${Math.round(this._value * 100 + Number.EPSILON)}%` : '';

@coderabbitai coderabbitai Bot Aug 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== file excerpt =="
if [ -f examples/pomodoro-timer/src/index.tsx ]; then
  nl -ba examples/pomodoro-timer/src/index.tsx | sed -n '140,205p'
else
  echo "missing examples/pomodoro-timer/src/index.tsx"
fi

echo
echo "== JS Node probe for exact value and proposed forms =="
node - <<'JS'
const value = 0.145;
const beforeRound = value * 100 + Number.EPSILON;
const proposedRound = (value + Number.EPSILON) * 100;
console.log(JSON.stringify({
  value: value,
  valueTimes100: value * 100,
  eps: Number.EPSILON,
  beforeRoundString: beforeRound.toString(),
  beforeRoundValue: beforeRound,
  beforeRound: Math.round(beforeRound),
  proposedRoundString: proposedRound.toString(),
  proposedRound: Math.round(proposedRound),
  exactThresholdBelowBy: Number.isFinite((100 * value) - 14.5) ? (100 * value) - 14.5 : 'not finite',
  beforeRoundBelowThresholdBy: beforeRound - 14.5,
  proposedRoundAboveThresholdBy: proposedRound - 14.5,
}, null, 2));
JS

Repository: Karanjot786/TermUI

Length of output: 215

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== file exists and line count =="
if [ -f examples/pomodoro-timer/src/index.tsx ]; then
  wc -l examples/pomodoro-timer/src/index.tsx
else
  echo "missing examples/pomodoro-timer/src/index.tsx"
  exit 0
fi

echo
echo "== file excerpt using sed =="
sed -n '140,205p' examples/pomodoro-timer/src/index.tsx

echo
echo "== JS Node probe for exact value and proposed forms =="
node - <<'JS'
const value = 0.145;
const beforeRound = value * 100 + Number.EPSILON;
const proposedRound = (value + Number.EPSILON) * 100;
console.log(JSON.stringify({
  value: value,
  valueTimes100: value * 100,
  eps: Number.EPSILON,
  beforeRoundString: beforeRound.toString(),
  beforeRoundValue: beforeRound,
  beforeRound: Math.round(beforeRound),
  proposedRoundString: proposedRound.toString(),
  proposedRound: Math.round(proposedRound),
  exactThresholdBelowBy: Number.isFinite((100 * value) - 14.5) ? (100 * value) - 14.5 : 'not finite',
  beforeRoundBelowThresholdBy: beforeRound - 14.5,
  proposedRoundAboveThresholdBy: proposedRound - 14.5,
}, null, 2));
JS

Repository: Karanjot786/TermUI

Length of output: 3166

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== search render/setValue usages in pomodoro example =="
rg -n "setValue|get value|label|0\.145|14\.5|GradientProgressBar|_value" examples/pomodoro-timer/src -S || true

echo
echo "== probe percentage rounding edge cases for multiply-then-add vs add-then-multiply =="
node - <<'JS'
function roundScale(value) { return Math.round(value * 100 + Number.EPSILON); }
function roundProposed(value) { return Math.round((value + Number.EPSILON) * 100); }

const xs = [0.145, 0.285, 0.425, 0.565, 0.705, 0.845, 0.985];
for (const x of xs) {
  console.log(`${x}: multiplyThenAdd=${roundScale(x)} addThenMultiply=${roundProposed(x)} diff=${roundScale(x)-roundProposed(x)}`);
}
JS

Repository: Karanjot786/TermUI

Length of output: 2499

Scale Number.EPSILON before rounding the percentage.

Line 185 adds an absolute epsilon after this._value * 100, which is too small at that scale. A value like 0.145 rounds to 14%; add the epsilon to the normalized value before multiplying, or round the percent value with a scale-appropriate epsilon.

Proposed fix 
-        const label = this._showLabel ? ` ${Math.round(this._value * 100 + Number.EPSILON)}%` : '';
+        const label = this._showLabel ? ` ${Math.round((this._value + Number.EPSILON) * 100)}%` : '';
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const label = this._showLabel ? ` ${Math.round(this._value * 100 + Number.EPSILON)}%` : '';
const label = this._showLabel ? ` ${Math.round((this._value + Number.EPSILON) * 100)}%` : '';
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@examples/pomodoro-timer/src/index.tsx` at line 185, Update the percentage
calculation in the label expression of the timer class so the epsilon is applied
at the normalized-value scale before multiplying by 100, or otherwise use an
equivalent scale-appropriate epsilon. Preserve the existing conditional label
behavior and rounded percentage output.

const barWidth = Math.max(0, width - label.length);
const filled = this._value <= 0 ? 0 : Math.round(barWidth * this._value);
const empty = barWidth - filled;
Expand Down
2 changes: 1 addition & 1 deletion examples/widget-gallery/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ class WidgetGalleryApp extends Widget {
}

// Tab switching: 1-6
const num = parseInt(event.key);
const num = parseInt(event.key, 10);
if (num >= 1 && num <= 6) {
this._switchTab(num - 1);
return true;
Expand Down
Loading