Skip to content

fix: resolve 4 bugs in termui #3571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saurabhhhcodes wants to merge 1 commit into from
Closed

fix: resolve 4 bugs in termui #3571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/pomodoro-timer/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ class GradientProgressBar extends Widget {

const attrs = styleToCellAttrs(this._style);

const label = this._showLabel ? ` ${Math.round(this._value * 100)}%` : '';
const label = this._showLabel ? ` ${Math.round(this._value * 100 + Number.EPSILON)}%` : '';

@coderabbitai coderabbitai Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Apply Number.EPSILON before scaling the progress value.

Number.EPSILON is added after this._value * 100, where the adjustment can be lost. For example, 0.145 * 100 can evaluate to 14.499999999999998, and the current expression still rounds to 14 instead of 15.

Proposed fix 
-        const label = this._showLabel ? ` ${Math.round(this._value * 100 + Number.EPSILON)}%` : '';
+        const label = this._showLabel ? ` ${Math.round((this._value + Number.EPSILON) * 100)}%` : '';
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const label = this._showLabel ? ` ${Math.round(this._value * 100 + Number.EPSILON)}%` : '';
const label = this._showLabel ? ` ${Math.round((this._value + Number.EPSILON) * 100)}%` : '';
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@examples/pomodoro-timer/src/index.tsx` at line 185, Update the label
calculation in the progress-rendering method to add Number.EPSILON to
this._value before multiplying by 100, ensuring values affected by
floating-point precision round to the expected percentage.

const barWidth = Math.max(0, width - label.length);
const filled = this._value <= 0 ? 0 : Math.round(barWidth * this._value);
const empty = barWidth - filled;
Expand Down
2 changes: 1 addition & 1 deletion packages/dev-server/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ export class DevServer {

this._killChild();

await exitedPromise.catch(() => {});
await exitedPromise.catch( => console.error());

@coderabbitai coderabbitai Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail
npx biome check packages/dev-server/src/server.ts

Repository: Karanjot786/TermUI

Length of output: 2385

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf 'Relevant server.ts line context:\n'
sed -n '370,390p' packages/dev-server/src/server.ts | nl -ba -v370

printf '\nParse probe for the exact callback form with Node TypeScript parser if available:\n'
node --version
node --input-type=module - <<'JS'
for (const src of [
  'await exitedPromise.catch( => console.error());',
  'await Promise.resolve().catch((err) => console.error("Child process exit failed:", err));',
]) {
  try {
    new Function(src);
    console.log('runtime syntax ok:', src);
  } catch (error) {
    console.log(`${error.name}: ${error.message.split('\n')[0]}`);
    console.log(src);
  }
}
JS

printf '\nTypeScript syntax check if local typescript is available:\n'
if command -v npx >/dev/null 2>&1; then
  npx -y typescript@latest -v
  cat > /tmp/check_syntax.ts <<'TS'
const exitedPromise = Promise.reject(new Error("x"));
await exitedPromise.catch( => console.error());
await exitedPromise.catch((err) => {
  console.error('Child process exit failed:', err);
});
TS
  npx -y typescript@latest --noEmit --strict /tmp/check_syntax.ts || true
else
  echo "npx unavailable"
fi

Repository: Karanjot786/TermUI

Length of output: 229

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf 'Relevant server.ts line context:\n'
sed -n '370,390p' packages/dev-server/src/server.ts | awk '{printf "%04d\t%s\n", NR+369, $0}'

printf '\nExact current line:\n'
sed -n '383p' packages/dev-server/src/server.ts | awk '{printf "\t%s\n", $0}'

printf '\nNode syntax probe for the callback form:\n'
node --version || true
node --input-type=module - <<'JS'
for (const label of ['bad', 'good']) {
  const src = label === 'bad'
    ? 'await exitedPromise.catch( => console.error());'
    : 'await Promise.resolve().catch((err) => console.error("Child process exit failed:", err));';
  try {
    new Function(src);
    console.log(label, 'passes JavaScript syntax check:', src);
  } catch (error) {
    console.log(label + '-syntax-error');
    console.log(error.name + ': ' + error.message.split('\n')[0]);
    console.log(src);
  }
}
JS

Repository: Karanjot786/TermUI

Length of output: 1544

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf 'Server.ts top-level await context:\n'
sed -n '350,390p' packages/dev-server/src/server.ts | awk '{printf "%04d\t%s\n", NR+349, $0}'

printf '\nNode syntax probe wrapped in an async function to isolate callback syntax:\n'
node --input-type=module - <<'JS'
function probe(label, body) {
  return { label, body, passes: (() => {
    try {
      new Function(body);
      return true;
    } catch (error) {
      return false;
    }
  })() };
}

for (const { label, body } of [
  probe('empty-arg-callback', 'return async function() { const exitedPromise = Promise.resolve(0); await exitedPromise.catch( => console.error()); };'),
  probe('typed-arg-callback', 'return async function() { const exitedPromise = Promise.resolve(0); await exitedPromise.catch((err) => console.error("Child process exit failed:", err)); };'),
]).results) {
  console.log(label + ': ' + (passes ? 'passes' : 'fails JavaScript syntax')) + body;
}
JS

Repository: Karanjot786/TermUI

Length of output: 2556

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf 'Node syntax probe for callback parameter syntax in async Promise.catch context:\n'
node --input-type=module - <<'JS'
async function run() {
  const entries = [
    { label: bad-argless-callback, body: 
'const exitedPromise = Promise.resolve(0);
await exitedPromise.catch( => console.error());'
    },
    { label: typed-err-callback, body:
'const exitedPromise = Promise.resolve(0);
await exitedPromise.catch((err) => console.error("Child process exit failed:", err));'
    },
  ];

  for (const entry of entries) {
    try {
      new Function(entry.body);
      console.log(entry.label + ": JavaScript syntax ok");
    } catch (error) {
      console.log(entry.label + ": JavaScript syntax fail");
      console.log(error.name + ": " + error.message.split("\n")[0]);
      console.log(entry.body);
    }
  }
}
run().catch(console.error);
JS

Repository: Karanjot786/TermUI

Length of output: 1057

🏁 Script executed:

#!/bin/bash
set -euo pipefail

tmpdir="$(mktemp -d)"
trap 'rm -rf "$tmpdir"' EXIT

cat > "$tmpdir/probe.js" <<'JS'
async function run() {
  const entries = [
    { label: "argless-arrow-catch", body: "const exitedPromise = Promise.resolve(0);\nawait exitedPromise.catch( => console.error());" },
    { label: "typed-err-arrow-catch", body: "const exitedPromise = Promise.resolve(0);\nawait exitedPromise.catch((err) => console.error(\"Child process exit failed:\", err));" },
  ];

  for (const entry of entries) {
    try {
      new Function(entry.body);
      console.log(entry.label + ": JavaScript syntax ok");
    } catch (error) {
      console.log(entry.label + ": JavaScript syntax fail");
      console.log(error.name + ": " + error.message.split("\n")[0]);
      console.log(entry.body);
    }
  }
}
run().catch(console.error);
JS

node "$tmpdir/probe.js"

printf '\nExact current line byte-level check for shorthand arrow token:\n'
sed -n '383p' packages/dev-server/src/server.ts | od -c | head -n 20

Repository: Karanjot786/TermUI

Length of output: 745

🏁 Script executed:

#!/bin/bash
set -euo pipefail

tmpdir="$(mktemp -d)"
trap 'rm -rf "$tmpdir"' EXIT

cat > "$tmpdir/probe.js" <<'JS'
function run() {
  const entries = [
    { label: "argless-arrow-catch", body: "const exitedPromise = Promise.resolve(0);\nawait exitedPromise.catch( => console.error());" },
    { label: "typed-err-arrow-catch", body: "const exitedPromise = Promise.resolve(0);\nawait exitedPromise.catch((err) => console.error(\"Child process exit failed:\", err));" },
  ];

  for (const entry of entries) {
    try {
      new Function(entry.body);
      console.log(entry.label + ": JavaScript syntax ok");
    } catch (error) {
      console.log(entry.label + ": JavaScript syntax fail");
      console.log(error.name + ": " + error.message.split("\n")[0]);
      console.log(entry.body);
    }
  }
}
run();
JS

node "$tmpdir/probe.js"

printf '\nLine 383 character stream:\n'
sed -n '383p' packages/dev-server/src/server.ts | tr '\n' '\0' | sed 's/./[&]/g' | tr '?' ' '

Repository: Karanjot786/TermUI

Length of output: 848

Replace the invalid .catch callback.

await exitedPromise.catch( => console.error()) has an invalid arrow-function parameter list. The callback also ignores the rejection, so diagnostics are lost if the child-exit promise rejects.

Use a valid rejection handler:

await exitedPromise.catch((err) => {
  console.error('Child process exit failed:', err);
});
🧰 Tools
🪛 Biome (2.5.6)

[error] 383-383: Expected a parenthesis '(' but instead found '=>'.

(parse)

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/dev-server/src/server.ts` at line 383, Fix the invalid rejection
callback on exitedPromise by providing a valid parameter and logging the
received error in the console.error call. Preserve awaiting exitedPromise while
including clear child-process exit failure context and diagnostic details.

Source: Linters/SAST tools


if (this._running && this._entryFile) {
this._spawnChild();
Expand Down
2 changes: 2 additions & 0 deletions packages/ui/src/Form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,3 +138,5 @@ export class Form extends Widget {
}
}
}

.catch(err => console.error("Promise.all failed:", err));
Comment on lines +141 to +142

@coderabbitai coderabbitai Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail
npx biome check packages/ui/src/Form.ts

Repository: Karanjot786/TermUI

Length of output: 631

Remove the detached .catch(...) after submit().

packages/ui/src/Form.ts(142,1) is invalid TypeScript: Promise.all is awaited inside submit(), and a standalone .catch(...) after the class is only parsed as a leading statement of the next class item. Attach it to Promise.all if a rejected validator should be caught, or move validation/error handling into try/catch/finally.

🧰 Tools
🪛 Biome (2.5.6)

[error] 142-142: Expected a statement but instead found '.catch(err => console.error("Promise.all failed:", err))'.

(parse)

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/ui/src/Form.ts` around lines 141 - 142, Remove the detached .catch
after submit() in Form, which is invalid because submit() already awaits
Promise.all. Attach rejection handling directly to the Promise.all call or move
it into submit()’s existing try/catch/finally flow, preserving validator error
handling.

Source: Linters/SAST tools

2 changes: 1 addition & 1 deletion packages/ui/src/Switch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export class Switch extends Widget {
if (width <= 0) return;

const attrs = styleToCellAttrs(this.style);
const knobPos = Math.round(this._animProgress * 2);
const knobPos = Math.round(this._animProgress * 2 + Number.EPSILON);
const transitioning = this._animProgress > 0 && this._animProgress < 1;

let trackChars: string[];
Expand Down
Loading