Skip to content

fix: resolve 4 bugs in termui #3520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saurabhhhcodes wants to merge 1 commit into from
Closed

fix: resolve 4 bugs in termui #3520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/calculator/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function safeEval(expr: string): string {
if (tokens.length === 0) return '0';

// Handle initial negative number
if (tokens[0] === '-' && tokens.length > 1 && !isNaN(Number(tokens[1]))) {
if (tokens[0] === '-' && tokens.length > 1 && !Number.isNaN(Number(tokens[1]))) {
tokens.splice(0, 2, '-' + tokens[1]);
}

Expand Down
2 changes: 1 addition & 1 deletion examples/forms-and-validation/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ class FormsExampleApp extends Widget {
return false; // Quit
}

if (event.key === 'c' && event.ctrl === false) {
if (event.key === 'c' && event.ctrl !) {

@coderabbitai coderabbitai Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

file="examples/forms-and-validation/src/index.tsx"

! rg -n 'event\.ctrl !' "$file"
rg -n 'event\.key === .c. && !event\.ctrl' "$file"

Repository: Karanjot786/TermUI

Length of output: 209

🏁 Script executed:

#!/bin/bash
set -euo pipefail

file="examples/forms-and-validation/src/index.tsx"

echo "== surrounding code =="
sed -n '115,132p' "$file" | cat -n

echo
echo "== TypeScript compiler availability =="
(command -v tsc && tsc --version) || true

echo
echo "== parse/type behavior for event.ctrl ! if tsc is available =="
if command -v tsc >/dev/null 2>&1; then
  tmp="$(mktemp -d)"
  cat > "$tmp/probe.ts" <<'TS'
interface KeyEvent { ctrl: boolean }
declare const event: KeyEvent;
if (event.key === 'c' && event.ctrl !) {
  const x: boolean = event.ctrl;
}
TS
  tsc --noEmit --strict "$tmp/probe.ts" 2>&1 || true
else
  echo "tsc not available"
fi

echo
echo "== exact current line =="
sed -n '125p' "$file"

Repository: Karanjot786/TermUI

Length of output: 1956

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== TS 7.0.2 parse/type behavior for event.ctrl ! (no DOM globals) =="
tmp="$(mktemp -d)"
cat > "$tmp/probe.ts" <<'TS'
declare function test(event: { key: string; ctrl: boolean }): void {
  if (event.key === 'c' && event.ctrl !) {
    const x: boolean = event.ctrl;
  }
}
TS
tsc --noEmit --strict "$tmp/probe.ts" 2>&1 || true

echo
echo "== TS 7.0.2 parse/type behavior without exclamation spacing =="
cat > "$tmp/probe2.ts" <<'TS'
declare function test(event: { key: string; ctrl: boolean }): void {
  if (event.key === 'c' && event.ctrl!) {
    const x: boolean = event.ctrl;
  }
}
TS
tsc --noEmit --strict "$tmp/probe2.ts" 2>&1 || true

Repository: Karanjot786/TermUI

Length of output: 739

🏁 Script executed:

#!/bin/bash
set -euo pipefail

tmp="$(mktemp -d)"
cat > "$tmp/keyboard-handler.tsx" <<'TS'
interface KeyEvent { key: string; ctrl: boolean }

function handle(event: KeyEvent) {
  if (event.key === 'q' || (event.ctrl && event.key === 'c')) {
    return false;
  }

  if (event.key === 'c' && event.ctrl !) {
    const yes: boolean = event.ctrl;
    return true;
  }
}
TS

tsc --noEmit --strict "$tmp/keyboard-handler.tsx" 2>&1 | sed -n '1,40p'

Repository: Karanjot786/TermUI

Length of output: 156

Use boolean negation for the clear-form shortcut.

event.ctrl ! becomes the postfix non-null assertion event.ctrl!, so the condition requires Ctrl. Plain c never opens the modal, while Ctrl+C exits earlier. Replace it with !event.ctrl.

Proposed fix 
-        if (event.key === 'c' && event.ctrl !) {
+        if (event.key === 'c' && !event.ctrl) {
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if (event.key === 'c' && event.ctrl !) {
if (event.key === 'c' && !event.ctrl) {
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@examples/forms-and-validation/src/index.tsx` at line 125, Update the
clear-form keyboard shortcut condition in the key event handler to use boolean
negation on event.ctrl, so it matches plain “c” without Ctrl and does not use
the postfix non-null assertion.

Source: Coding guidelines

this.modal.show();
return true;
}
Expand Down
2 changes: 1 addition & 1 deletion examples/pomodoro-timer/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ class GradientProgressBar extends Widget {

const attrs = styleToCellAttrs(this._style);

const label = this._showLabel ? ` ${Math.round(this._value * 100)}%` : '';
const label = this._showLabel ? ` ${Math.round(this._value * 100 + Number.EPSILON)}%` : '';

@coderabbitai coderabbitai Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

node <<'NODE'
const value = 29 / 200;
const current = Math.round(value * 100 + Number.EPSILON);
const corrected = Math.round((value + Number.EPSILON) * 100);

if (current !== 14 || corrected !== 15) {
  throw new Error(JSON.stringify({ value, current, corrected }));
}
NODE

Repository: Karanjot786/TermUI

Length of output: 156

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect the relevant implementation around setValue and the label rendering.
file="examples/pomodoro-timer/src/index.tsx"
if [ -f "$file" ]; then
  wc -l "$file"
  sed -n '1,230p' "$file" | nl -ba
else
  echo "File not found: $file"
fi

# Read-only behavioral probe for the edge cases that can appear from clamped [0,1] values.
node <<'NODE'
function current(value, showLabel = true) {
  return showLabel ? Math.round(value * 100 + Number.EPSILON) : '';
}
function corrected(value, showLabel = true) {
  return showLabel ? Math.round((value + Number.EPSILON) * 100) : '';
}

const cases = [
  29 / 200,
  1 / 200,
  28 / 200,
  30 / 200,
  50 / 200,
];
for (const value of cases) {
  const exact = value * 100;
  const displayCurrent = current(value);
  const displayCorr = corrected(value);
  const mathExactRound = Math.round(exact);
  console.log(JSON.stringify({ value, exact, current: displayCurrent, corrected: displayCorr, mathExactRound }));
}
NODE

Repository: Karanjot786/TermUI

Length of output: 238

🏁 Script executed:

#!/bin/bash
set -euo pipefail

file="examples/pomodoro-timer/src/index.tsx"
printf '--- line count ---\n'
wc -l "$file"

printf '\n--- lines 140-210 ---\n'
sed -n '140,210p' "$file"

printf '\n--- setValue and progress symbol occurrences ---\n'
grep -nE 'setValue|_value|showLabel|Number.EPSILON|Math.round' "$file" || true

Repository: Karanjot786/TermUI

Length of output: 247

🏁 Script executed:

#!/bin/bash
set -euo pipefail

file="examples/pomodoro-timer/src/index.tsx"

printf '%s\n' '--- line count ---'
wc -l "$file"

printf '%s\n' ''
printf '%s\n' '--- lines 140-210 ---'
sed -n '140,210p' "$file"

printf '%s\n' ''
printf '%s\n' '--- setValue and progress symbol occurrences ---'
grep -nE 'setValue|_value|showLabel|Number.EPSILON|Math.round' "$file" || true

printf '%s\n' ''
printf '%s\n' '--- behavioral probe ---'
node <<'NODE'
function current(value, showLabel = true) {
  return showLabel ? Math.round(value * 100 + Number.EPSILON) : '';
}
function corrected(value, showLabel = true) {
  return showLabel ? Math.round((value + Number.EPSILON) * 100) : '';
}

const cases = [
  29 / 200,
  1 / 200,
  28 / 200,
  30 / 200,
  50 / 200,
];
for (const value of cases) {
  const exact = value * 100;
  const displayCurrent = current(value);
  const displayCorr = corrected(value);
  const mathExactRound = Math.round(exact);
  console.log(JSON.stringify({ value, exact, current: displayCurrent, corrected: displayCorr, mathExactRound }));
}
NODE

Repository: Karanjot786/TermUI

Length of output: 4790

Fix the progress percentage rounding.

setValue(29 / 200) rounds to 14% because 0.145 * 100 + Number.EPSILON still rounds down. Add epsilon before scaling the percentage.

-        const label = this._showLabel ? ` ${Math.round(this._value * 100 + Number.EPSILON)}%` : '';
+        const label = this._showLabel ? ` ${Math.round((this._value + Number.EPSILON) * 100)}%` : '';
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const label = this._showLabel ? ` ${Math.round(this._value * 100 + Number.EPSILON)}%` : '';
const label = this._showLabel ? ` ${Math.round((this._value + Number.EPSILON) * 100)}%` : '';
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@examples/pomodoro-timer/src/index.tsx` at line 185, Update the percentage
calculation in the label expression to add Number.EPSILON to the fractional
value before multiplying by 100, so values such as setValue(29 / 200) round to
15%. Preserve the existing conditional label behavior and rounding.

const barWidth = Math.max(0, width - label.length);
const filled = this._value <= 0 ? 0 : Math.round(barWidth * this._value);
const empty = barWidth - filled;
Expand Down
Loading