Skip to content

fix: resolve 4 bugs in termui #3519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saurabhhhcodes wants to merge 1 commit into from
Closed

fix: resolve 4 bugs in termui #3519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/todo-app/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ class CustomMultiProgress extends (MultiProgressClass as any) {
const value = Math.max(0, Math.min(1, item.value));
const filled = Math.round(barWidth * value);

const pct = Math.round(value * 100);
const pct = Math.round(value * 100 + Number.EPSILON);

@coderabbitai coderabbitai Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Apply the epsilon before scaling.

Number.EPSILON is too small after value * 100 for some boundary values. For example, 0.145 * 100 becomes 14.499999999999998; adding Number.EPSILON still rounds to 14 instead of 15.

Move the epsilon before multiplication, or scale it to the percentage value. Add a boundary test for value = 0.145.

Proposed fix 
-            const pct = Math.round(value * 100 + Number.EPSILON);
+            const pct = Math.round((value + Number.EPSILON) * 100);
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const pct = Math.round(value * 100 + Number.EPSILON);
const pct = Math.round((value + Number.EPSILON) * 100);
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@examples/todo-app/src/index.ts` at line 107, Update the percentage
calculation using pct so the epsilon is applied before scaling, or equivalently
scale the epsilon for percentage units, ensuring boundary value 0.145 rounds to
15. Add a boundary test covering value = 0.145 and preserve the existing
rounding behavior for other values.

const percentStr = ` ${pct}% `;
const showPct = barWidth >= percentStr.length;
const labelStart = showPct ? Math.floor((barWidth - percentStr.length) / 2) : -1;
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/prompts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ async function promptSelect<T = string>(options: SelectPromptOptions<T>): Promis
return;
}
const n = parseInt(trimmed, 10);
if (!isNaN(n) && n >= 1 && n <= choices.length) {
if (!Number.isNaN(n) && n >= 1 && n <= choices.length) {
Comment on lines 115 to +116

@coderabbitai coderabbitai Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== files =="
git ls-files | rg '(^|/)prompts\.(ts|test\.ts)$|(^|/)prompts\.ts$' || true

echo "== prompts outline =="
if [ -f packages/ui/src/prompts.ts ]; then
  ast-grep outline packages/ui/src/prompts.ts || true
  echo "== relevant lines =="
  nl -ba packages/ui/src/prompts.ts | sed -n '90,135p'
fi

echo "== tests around prompts =="
if [ -f packages/ui/src/prompts.test.ts ]; then
  nl -ba packages/ui/src/prompts.test.ts | sed -n '1,220p'
fi

echo "== behavioral probe for JS parseInt Number Number.isInteger =="
node - <<'JS'
const vals = ["1", "  1  ", "1abc", "1.5", "-01", "abc", "1e2", "01abc", "1.abc", ""];
for (const trimmed of vals.map(s => s.trim())) {
  const parseIntVal = parseInt(trimmed, 10);
  const numberVal = Number(trimmed);
  console.log(JSON.stringify({
    input: trimmed,
    parseInt: parseIntVal,
    Number: numberVal,
    Number_isInteger: Number.isInteger(numberVal)
  }));
}
JS

Repository: Karanjot786/TermUI

Length of output: 1799

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== relevant lines: packages/ui/src/prompts.ts =="
awk 'NR>=91 && NR<=130 {printf "%5d\t%s\n", NR, $0}' packages/ui/src/prompts.ts

echo "== prompts tests first 240 lines =="
if [ -f packages/ui/src/prompts.test.ts ]; then
  awk '{printf "%5d\t%s\n", NR, $0}' packages/ui/src/prompts.test.ts | sed -n '1,240p'
fi

echo "== behavioral probe for JS parseInt Number Number.isInteger =="
node - <<'JS'
const vals = ["1", "  1  ", "1abc", "1.5", "-01", "abc", "1e2", "01abc", "1.abc", ""];
for (const trimmed of vals.map(s => s.trim())) {
  const parseIntVal = parseInt(trimmed, 10);
  const numberVal = Number(trimmed);
  console.log(JSON.stringify({input: trimmed, parseInt: parseIntVal, Number: numberVal, Number_isInteger: Number.isInteger(numberVal)}));
}
JS

Repository: Karanjot786/TermUI

Length of output: 5429

Make the choice parser validate the full input.

n comes from parseInt, so it is always a number or NaN; Number.isNaN(n) and isNaN(n) produce the same result. The parser also accepts inputs like 1abc because parseInt returns 1. Parse the complete token and require an integer. Add regression tests for malformed inputs such as 1abc and fractional inputs such as 1.5 in packages/ui/src/prompts.test ts.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/ui/src/prompts.ts` around lines 115 - 116, Update the choice parser
around n to validate the entire trimmed token rather than relying on parseInt,
rejecting malformed suffixes such as 1abc and fractional values such as 1.5
while accepting only valid integer choices within choices.length. Add regression
coverage in the prompts tests for both invalid input cases.

rl.close();
resolve(choices[n - 1].value);
return;
Expand Down
2 changes: 1 addition & 1 deletion scripts/build-registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export function collectDeps(content: string): string[] {
const deps = new Set<string>();
let m: RegExpExecArray | null;
while ((m = re.exec(content)) !== null) deps.add(m[1]!);
return [...deps].sort();
return [...deps].sort((a, b) => a - b);

@coderabbitai coderabbitai Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

rg -n -C 3 'const deps = new Set<string>|sort\(\(a, b\) => a - b\)' scripts/build-registry.ts
rg -n -C 8 'collects unique sorted' scripts/build-registry.test.ts

Repository: Karanjot786/TermUI

Length of output: 1266

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf 'TypeScript compiler availability:\n'
(tsc --version 2>&1) || true

printf '\nbuild-registry relevant lines:\n'
sed -n '30,55p' scripts/build-registry.ts | cat -n

printf '\nDependency parsing context:\n'
rg -n -C 2 'collectDeps|toSlug|buildRegistry|registry' scripts/build-registry.ts

printf '\nTypeScript type-check probe for subtraction of strings:\n'
tmp="$(mktemp -d)"
cat > "$tmp/minus.ts" <<'TS'
const deps = new Set<string>();
const sorted = [...deps].sort((a: string, b: string) => a - b);
export { sorted };
TS
if command -v tsc >/dev/null 2>&1; then
  tsc --strict --noEmit "$tmp/minus.ts" 2>&1
else
  node - <<'JS'
const deps = new Set(['b', 'a']);
const sorted = [...deps].sort((a, b) => a - b);
console.log('runtime sorted:', JSON.stringify(sorted));
JS
fi

Repository: Karanjot786/TermUI

Length of output: 4344

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf 'Runtime sub-sort probe:\n'
node - <<'JS'
const samples = [
  ['b', 'a'],
  ['`@termuijs/widgets`', '`@termuijs/core`'],
  ['z', 'aa'],
];
for (const deps of samples) {
  const sortedSub = [...deps].sort((a, b) => a - b);
  const sortedCompare = [...deps].sort((a, b) => a.localeCompare(b));
  console.log(JSON.stringify({ input: deps, subSorted: sortedSub, localeCompare: sortedCompare }));
}
JS

printf '\nPackage TypeScript declaration check:\n'
sed -n '1,120p' package.json | json_pp 2>/dev/null || sed -n '1,120p' package.json

Repository: Karanjot786/TermUI

Length of output: 1794

Use a string comparator for dependency sorting.

collectDeps stores Set<string> values, but sorts with a - b. TypeScript rejects subtraction on strings, and string subtraction produces NaN, so the comparator does not change non-alphabetical input.

-  return [...deps].sort((a, b) => a - b);
+  return [...deps].sort((a, b) => a.localeCompare(b));
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
return [...deps].sort((a, b) => a - b);
return [...deps].sort((a, b) => a.localeCompare(b));
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/build-registry.ts` at line 47, Update the dependency sorting in
collectDeps to use a lexicographic string comparator rather than numeric
subtraction, preserving alphabetical ordering of the Set<string> values.

Source: Coding guidelines

}

export function toSlug(name: string): string {
Expand Down
Loading