Skip to content

fix : added ASCII fallback for LineChart and SplitPane Unicode characters - #3439

Open
tmdeveloper007 wants to merge 2 commits into
Karanjot786:mainfrom
tmdeveloper007:fix/linechart-splitpane-ascii-fallback
Open

fix : added ASCII fallback for LineChart and SplitPane Unicode characters#3439
tmdeveloper007 wants to merge 2 commits into
Karanjot786:mainfrom
tmdeveloper007:fix/linechart-splitpane-ascii-fallback

Conversation

@tmdeveloper007

Copy link
Copy Markdown
Contributor

Description

Fixes a bug in the LineChart and SplitPane widgets where various characters (Y-axis tick marks , vertical connectors , X-axis lines , origin corners , and vertical split dividers) always render in Unicode, even when the terminal does not support Unicode. This causes display issues on ASCII-only terminals.

The fix adds caps.unicode checks across both widgets, falling back to ASCII equivalents (+, |, -) when Unicode is disabled.

Changes

  • packages/widgets/src/data/LineChart.ts — replaced , , , with caps.unicode checks
  • packages/widgets/src/data/LineChart.test.ts — added tests for Y-axis, X-axis, and tick mark ASCII fallbacks
  • packages/widgets/src/layout/SplitPane.ts — replaced with caps.unicode ? '─' : '-' for vertical split divider
  • packages/widgets/src/layout/SplitPane.test.ts — added test for vertical split ASCII fallback

Related Issues

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

Checklist

  • Code follows the existing style
  • Tests added or updated
  • Documentation updated (if applicable)
  • All tests pass locally

Note: Please assign this PR to the tmdeveloper007 account.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@tmdeveloper007, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a7442e3f-6f3c-43c7-a58c-dcc5c48ce854

📥 Commits

Reviewing files that changed from the base of the PR and between 6c7584e and 470f456.

📒 Files selected for processing (6)
  • packages/widgets/src/data/LineChart.test.ts
  • packages/widgets/src/data/LineChart.ts
  • packages/widgets/src/display/Code.test.ts
  • packages/widgets/src/display/Code.ts
  • packages/widgets/src/layout/SplitPane.test.ts
  • packages/widgets/src/layout/SplitPane.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added area:widgets @termuijs/widgets type:testing +10 pts. Tests. labels Aug 3, 2026
@tmdeveloper007 tmdeveloper007 reopened this Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:widgets @termuijs/widgets type:testing +10 pts. Tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix : LineChart and SplitPane widgets render Unicode chars without ASCII fallback

1 participant