fix : added ASCII fallback for Chart widget axis characters - #3438
fix : added ASCII fallback for Chart widget axis characters#3438tmdeveloper007 wants to merge 2 commits into
Conversation
|
Warning Review limit reached
Next review available in: 59 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Fixes a bug in the Chart widget where axis lines always render with Unicode box-drawing characters (
│,─,└,┤), even when the terminal does not support Unicode. This causes display issues on ASCII-only terminals.The fix adds
caps.unicodechecks for all axis characters, falling back to|,-,+when Unicode is disabled.Changes
packages/widgets/src/data/Chart.ts— addedaxisVert,axisHoriz,axisCorner,axisTickconstants usingcaps.unicodepackages/widgets/src/data/Chart.test.ts— added test verifying ASCII axis fallbackRelated Issues
Type of Change
Checklist
Note: Please assign this PR to the
tmdeveloper007account.