UI dark mode, tab name sync, field search, repo import fix#998
Merged
Conversation
New notebook tabs showed "<project> config" until refresh because the tab name was computed before the document loaded. Rename open tabs when the project updates so the real name appears immediately.
Rename open tabs when the project updates so a new notebook's tab shows its real name instead of "<project> config" until refresh. Extract the tab-name-sync and close-missing-document effects into testable functions and add unit tests for both.
Move the standalone flexlayout-model functions (create, open/close/rename tabs, preview, tree toggle, reset) into a LayoutModel class that holds the model. ProjectLayout now just calls its methods. Tests updated to match.
Support `type:`, `resource:`, `desc:` and dotted paths (e.g. desc.groupName:flat) in the tree search, ANDing whitespace-separated terms. Unknown field roots match nothing and show a warning under the search box. Plain text still searches all values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.