UI inline autocomplete, fix node edges, type change param reconcile#991
Merged
Conversation
Typing inside a {…} reference in an input field shows a floating
suggestion list: node names, then that node's outputs. Field keeps
focus; ↑/↓/Enter/Tab/Esc and click supported.
- workflowDataflow: tokenAtCaret, replaceReferenceAt
- add WorkflowInlineReference popup
- thread optional onValueCaret hook to the leaf editor
- extract INPUT_PARAMETERS_KEY constant
- tests for helpers and popup
Give every handle a node-scoped id (<node>:req-out/req-in, <node>:out:<name>, <node>:in:<param>) so a node's requires and dataflow handles no longer collide. parseDataflowConnection matches the :out:/:in: markers, so requires handles aren't taken for dataflow.
Keep valued params, drop empty ones, seed the new type's params; shared params keep their value. Logic in new nodeTypeParams.paramsOnTypeChange, replacing prefilledParameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.