test: add Hermes workflow integration tests refs #958#969
Merged
Conversation
Adds TestSimpleHermesWorkflow with 4 tests verifying a single-node RunPythonCode workflow builds and runs to completion via the local Luigi scheduler (no dispatch_id required). Tests are auto-skipped when hermes or luigi are not importable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Mark TestSimpleHermesWorkflow with @pytest.mark.integration — it runs actual Luigi workflows in subprocesses and requires hermes + luigi. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Closed
… check Addresses review feedback (#958): Luigi can exit 0 even when a task fails, so the return-code check alone isn't sufficient. Folds the stderr-summary assertion into test_single_node_workflow_completes and removes test_luigi_reports_success, which duplicated the same run. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Collaborator
Author
|
Pushed 8bde6d1 addressing both comments:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hera/tests/test_hermes_workflow.pywith 4@pytest.mark.integrationtests covering single-node, linear chain, branching, and error-propagation Hermes workflowspython -m luigi --local-scheduler, skipped automatically when Hermes is not installedTest plan
pytest hera/tests/test_hermes_workflow.py -v— 4 passedCloses #958
🤖 Generated with Claude Code