Skip to content

started main page - #6

Open
divya144 wants to merge 3 commits into
KamandPrompt:masterfrom
divya144:master
Open

started main page#6
divya144 wants to merge 3 commits into
KamandPrompt:masterfrom
divya144:master

Conversation

@divya144

Copy link
Copy Markdown

This adds a navigation bar and a links to sample dash-board and table.

Comment thread client/src/app/app.component.html Outdated
</mat-select>
</mat-form-field>
</div> -->
<!---->

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all of the commented unnecessary code.

Comment thread client/src/app/app.component.scss Outdated
position: absolute;
left:5%;
top:30%;
} No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line should be there at the end of each file.

Comment thread client/src/app/app.component.ts Outdated
value: string;
viewValue: string;
}
export interface gend{

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start the name of Interfaces with capital letter and variables with small like this, gender: Gender = []

Comment thread client/src/app/app.component.ts Outdated
export class AppComponent {
title = 'client';
spec: specialist[]=[
{value:'1',viewValue:'Dermatologist'},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run ng lint command in the client folder and resolve all the errors and then commit.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you should use nglint extension of vscode to check the errors. You can auto-indent the code in it using Ctrl + Shift + P then click on Beautify File option to auto indent everything, make sure to do it every file.

{path:'mynav',component:MynavComponent},
{path: 'dash',component: MydashComponent},
{path:'table',component:MytableComponent}
];

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navbar and table are not something you'll route to, they'll always be on screen so remove their routes and change dash to dashboard in dashboard path.

Comment thread client/npm-debug.log
23 error Or if that isn't available, you can get their info via:
23 error npm owner ls client
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never add debug log in your commits, always delete them before opening a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants