Refactor pytorch logic - #130
Merged
Merged
Conversation
chani0343
reviewed
Nov 11, 2025
| device=device, | ||
| weights_path=model_path, | ||
| class_mapping=class_mapping, | ||
| ) |
Collaborator
There was a problem hiding this comment.
model_class = mapping[model_type]
return model_class(
device=device,
weights_path=model_path,
class_mapping=class_mapping,
)
Dead code at end of create() method - remove the unreachable model_class = mapping[model_type] lines.
lyuzinmaxim
reviewed
Nov 11, 2025
| @@ -1,37 +1,28 @@ | |||
| #!/usr/bin/env python3 | |||
lyuzinmaxim
reviewed
Nov 11, 2025
| @@ -1,15 +1,18 @@ | |||
| #!/usr/bin/env python3 | |||
lyuzinmaxim
reviewed
Nov 11, 2025
| import torch | ||
| from PIL import Image | ||
|
|
||
| from src.inference.base.classifier_inference_base import ClassifierInferenceBase as InferenceModel |
Collaborator
There was a problem hiding this comment.
Could you please import it as is, and use directly ClassifierInferenceBase?
lyuzinmaxim
reviewed
Nov 11, 2025
|
|
||
|
|
||
| # Main image processing logic | ||
| def process_images_with_oop(model_type: str, model_path: str, image_dir: str, device: str): |
Collaborator
There was a problem hiding this comment.
please rename this function
lyuzinmaxim
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the PyTorch-related inference modules to improve structure, readability, and maintainability.
Changes
ResNetInference,MobileNetInference) intosrc/inference/pytorch/.src/inference/base/classifier_inference_base.py.InferenceFactoryto instantiate model classes dynamically.src/inference/utils/with logical grouping.closes #119