Skip to content

chore(ci): run cargo test with --all-features in lint-and-unit job - #39

Merged
kalaris-labs merged 1 commit into
mainfrom
chore/ci-all-features-tests
Sep 13, 2026
Merged

kalaris-labs merged 1 commit into
mainfrom
chore/ci-all-features-tests

Conversation

@kalaris-labs

@kalaris-labs kalaris-labs commented Sep 13, 2026 •

Copy link
Copy Markdown
Member

User description

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New threat detector or rule enhancement (SDTM-v1 class)
  • Performance optimization (throughput / RSS / binary size)
  • Documentation update
  • Other (please describe):

Four-Item Detector Checklist (Required if modifying/adding detectors)

If this PR adds or modifies a threat detector (SD-01 through SD-11), verify that all four items are included:

  • 1. Rule: Rule file in rules/ (e.g. rules/sd_0X_*.yar) or static engine pattern registered to an SDTM-v1 threat class in taxonomy.rs.
  • 2. Positive Fixture: Synthetic malicious skill in tests/fixtures/attack/SD-XX/ that triggers the finding.
  • 3. Hard-Negative Fixture: Clean/benign skill that exercises similar syntax but does NOT trigger a finding (zero false positives).
  • 4. Automated Test: Test in crates/skill-doctor-core/tests/ verifying positive fixture triggers failure and hard-negative passes.

Invariant Verification Checklist

  • Invariant 1 (Pure Rust): Zero Python/Node/shell required on product scan runtime.
  • Invariant 2 (Offline & Deterministic): Default scan path requires zero network and zero LLMs.
  • Invariant 3 (Additive-Only): L2/L3/L4 never suppress or downgrade L1 findings.
  • Invariant 4 (Determinism): Consecutive scans produce bit-identical reports.
  • Invariant 5 (Build-time Compilation): Rules compiled in build.rs, zero scan-time compilation.
  • Invariant 6 (Neutralization): No unneutralized input passed to models.
  • Invariant 7 (No Secret Values): Only secret key names, never raw values in reports.
  • Invariant 8 (CLI First): Default binary is lean and standalone.
  • Invariant 9 (Scope Limit): SDTM-v1 stays bounded at exactly 11 classes (SD-01 through SD-11).

Pre-Push Verification

  • cargo fmt --all --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace

CodeAnt-AI Description

Run the complete feature set in CI tests

What Changed

  • CI now runs workspace unit and integration tests with all features enabled
  • Feature-specific code paths are included in automated test coverage

Impact

✅ Earlier detection of feature-specific test failures
✅ Fewer regressions in optional features

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Summary by CodeRabbit

  • Tests
    • Expanded automated test coverage to run across all available feature combinations.
    • Ensured tests use locked dependency versions for consistent results.

RetriggerConfidence Score: 5/5

Safe to merge.

What we checked:

  • The executable wrapper was updated to use the exact updated workspace test invocation. T-Rex
  • The wrapper produced complete observed output showing a successful run with exit code 0 and passing results for all workspace targets. T-Rex
  • The executable wrapper contains the exact CI command trex-artifacts/ci-command-01-before.sh. T-Rex
  • The after-run log shows a successful run with exit code 0 and all tests passing, with the log available via the provided URL. T-Rex

Summary

  • The workspace test invocation now enables all Cargo features. The complete locked workspace test run passed, including feature-gated targets.

Reviews (1) · Last reviewed commit: "chore(ci): run cargo test with --all-fea..."

@hacktron-app

hacktron-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

Hacktron Security Check - Skipped

Reason: Billing required for Code Review seats

Add a payment method and start Code Review seat billing in organization billing settings

Go to: https://app.hacktron.ai/kalarislabs/billing

@codeant-ai

codeant-ai Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 913220f Sep 13, 2026 · 04:20 04:22

@codeant-ai

codeant-ai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@coderabbitai

coderabbitai Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 1a36d75f-b0a8-4836-9116-48181d9d24a3

📥 Commits

Reviewing files that changed from the base of the PR and between e18e72d and 913220f.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The CI workflow updates the lint-and-unit job to run workspace tests with all Cargo features enabled and locked dependencies.

Changes

CI test coverage

Layer / File(s) Summary
Enable all-feature workspace tests
.github/workflows/ci.yml
The Unit & Integration tests step now runs cargo test --workspace --all-features --locked.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 91322

The CI change broadens workspace test coverage to all Cargo features without an identified merge-blocking issue.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: enabling --all-features for Cargo tests in the lint-and-unit CI job.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/ci-all-features-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Sep 13, 2026
@kalaris-labs
kalaris-labs merged commit a5f567c into main Sep 13, 2026
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants