Skip to content

Comparer: Show info for all files include merged, sub wz (Fix #166) - #167

Draft
KENNYSOFT wants to merge 1 commit into
Kagamia:masterfrom
KENNYSOFT:feature/compare-info-all
Draft

Comparer: Show info for all files include merged, sub wz (Fix #166)#167
KENNYSOFT wants to merge 1 commit into
Kagamia:masterfrom
KENNYSOFT:feature/compare-info-all

Conversation

@KENNYSOFT

Copy link
Copy Markdown
Contributor

#166

image

We may provide some preference to collapse this long list.

@Kagamia

Kagamia commented Oct 4, 2021

Copy link
Copy Markdown
Owner

Do we really need to show them all?

And we can use <details> and <summary> to collapse file tree.

@KENNYSOFT

Copy link
Copy Markdown
Contributor Author

@PirateIzzy Any suggestion? 🤔

@PirateIzzy

Copy link
Copy Markdown
Contributor

@KENNYSOFT

I'm thinking of a few options:

  1. Combine all of them into a single output, so the total size of the old Character.wz -> the total size of the new Character.wz
  2. Add a summary on the top (like the current version), and a full comparison on the bottom of the comparison report.
    2.1. Maybe with this, we could change the layout of the comparison to show just the WZ files, rather than the full directory, and changing it to be a side-by-side WZ comparison, like so:
    Mockup

@KENNYSOFT
KENNYSOFT marked this pull request as draft October 5, 2021 00:35
@Kagamia

Kagamia commented Oct 5, 2021

Copy link
Copy Markdown
Owner

My purpose is always to keep the sub files and folders transparent to wzlib users, so I prefer option 1.

For those who really interested in sub files, I think it's better to provide a expandable list in report file, but it is a little more difficult to collapse file list in a html table.

We still need to provide full path to wz file, because most of us have more than one version of Maplestory Client.

  file size ver
new + D:\kmst\data\character\character.wz 1,000,000,000 (total) 1129
  |--- character.wz 63
  |--- character_000.wz xx
  |--- accessory\accessory.wz 63
  |--- accessory\accessory_000.wz 63
old + D:\kms\character.wz 1,100,000,000 (total) 351
date 2021-10-05 xx:xx
params -xxx

@PirateIzzy

Copy link
Copy Markdown
Contributor

Alright, understood. And that can work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants