Comparer: Show info for all files include merged, sub wz (Fix #166) - #167
Draft
KENNYSOFT wants to merge 1 commit into
Draft
Comparer: Show info for all files include merged, sub wz (Fix #166)#167KENNYSOFT wants to merge 1 commit into
KENNYSOFT wants to merge 1 commit into
Conversation
Owner
|
Do we really need to show them all? And we can use <details> and <summary> to collapse file tree. |
Contributor
Author
|
@PirateIzzy Any suggestion? 🤔 |
Contributor
KENNYSOFT
marked this pull request as draft
October 5, 2021 00:35
Owner
|
My purpose is always to keep the sub files and folders transparent to wzlib users, so I prefer option 1. For those who really interested in sub files, I think it's better to provide a expandable list in report file, but it is a little more difficult to collapse file list in a html table. We still need to provide full path to wz file, because most of us have more than one version of Maplestory Client.
|
Contributor
|
Alright, understood. And that can work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

#166
We may provide some preference to collapse this long list.