Add code review for PR #4 (multipass performance optimizations)

[Copilot]

PR #4 introduces ~4.3x multipass speedup via mmap-based I/O caching, bitset connectivity, and reduced per-node overhead. This PR documents a full review identifying correctness and safety issues in those changes.

Critical: Race conditions in parallel loops (freight.cpp)

nodes_moved unsynchronized write:

#pragma omp parallel for schedule(runtime)
for (LongNodeID curr_node = 0; ...) {
    ...
    if (config.restream_number > 0 && block != old_block_for_move_check)
        nodes_moved++;  // data race — no atomic/critical
}

Fix: #pragma omp atomic or std::atomic<LongNodeID>.

first_pass_bits / first_pass_connectivity concurrent RMW:
Multiple threads can race on the same net_idx slot (bit-OR) and on the shared double accumulator. Fix: std::atomic<uint64_t> for bitset words and #pragma omp atomic for the accumulator, or accumulate connectivity in a post-parallel pass over the bitset.

Medium issues

• open() unchecked before fstat() (both graph_io_stream.h): fd == -1 is silently passed to fstat, leaving st.st_size indeterminate before the mmap call.
• Duplicate if/else bodies in OMP critical guards (both vertex_partitioning.h): both branches contain the same call — only the pragma differs; the duplication should be collapsed.
• PGO CMake flags are GCC/Clang-only (both CMakeLists.txt): -fprofile-generate/-fprofile-use need a CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang" guard.
• evaluate_cut/evaluate_connectivity lack default initializers in partition_config.h — UB if the struct is used before standard() runs.
• Stale .size() call in prefetch guard (graph_io_stream.cpp): guard uses line_numbers.size() instead of the pre-computed line_size.
• best_cut/best_con/best_qap/best_pins set but never read — the intended skip of the final re-evaluation is incomplete.

Minor

• Removal of config.remaining_stream_nodes-- in readNodeOnePass_netl lacks a comment explaining why it is safe in all modes.
• cursor = curr_node alias is redundant; use curr_node directly.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/graphql
  • Triggering command: /usr/bin/gh gh auth status (http block)
• https://api.github.com/repos/KaHIP/FREIGHT/pulls/4
  • Triggering command: /usr/bin/curl curl -s -H Authorization: token ****** REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

review the latesr pr and add comments

[codacy-production]

Not up to standards ⛔

🔴 Issues 8 minor

Alerts:
⚠ 8 issues (≤ 0 issues of at least minor severity)

Results:
8 new issues

Category	Results
BestPractice	1 minor
CodeStyle	7 minor

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}

[Copilot]

Copilot wasn't able to review any files in this pull request.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.