fix: guard against empty choices and message=None in LLM client#26
Merged
Merged
Conversation
chat.completions.create() can return choices=[] (content-policy rejections, provider errors) or choices[0].message=None (e.g. Gemini PROHIBITED_CONTENT via OpenAI-compatible endpoint, HTTP 200). Both crash with IndexError/AttributeError. Guards added to both sync complete() and async complete_async() paths.
adaamko
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add guards in
LLMClient.complete()andLLMClient.complete_async()before accessingresponse.choices[0].message.content.Why
chat.completions.create()can return two empty-response shapes, both unhandled:choices = []— on content-policy rejections, rate-limit errors, or provider failureschoices[0].message = None— Gemini 2.5 Flash (via the OpenAI-compatible endpoint) returns HTTP 200 withfinish_reason: PROHIBITED_CONTENTandmessage=Nonerather than raising an exceptionBoth crash with
IndexErrororAttributeError. For a hallucination-prevention RAG system that may query multiple providers, silent crashes degrade the reliability guarantees the library is designed to provide.Change
Applied to both
complete()(sync) andcomplete_async()(async).Corpus context
Detected by
pact(llm_response_unguardedmode), a Z3-verified static analyzer for LLM crash vectors. This pattern was found across 13.7k violations in 786 repos.