Skip to content

Remove unused env files + fix root import for local runs - #104

Open
nshadskiy wants to merge 3 commits into
mainfrom
updates
Open

Remove unused env files + fix root import for local runs#104
nshadskiy wants to merge 3 commits into
mainfrom
updates

Conversation

@nshadskiy

Copy link
Copy Markdown
Contributor

This pull request removes several Conda environment YAML files and refactors the command construction in the run method of processor/tasks/CROWNMain.py to use wrap_executable_command.

@moritzmolch moritzmolch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comments:

  • In the .env file, we define the python version to be 3.9.*, while the LCG stack that we currently use in CROWN already supports python 3.12. We should think about upgrading the python version in the KingMaker environment.

  • We create a separate environment conda env, meaning that we have two conda environments in the image: base and env. To my understanding, there is no reason why we need to create a encapsulated environment inside the container. We could just use the base environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants