Conversation
moritzmolch
reviewed
Aug 10, 2026
moritzmolch
left a comment
Contributor
There was a problem hiding this comment.
General comments:
-
In the
.envfile, we define the python version to be3.9.*, while the LCG stack that we currently use inCROWNalready supports python 3.12. We should think about upgrading the python version in the KingMaker environment. -
We create a separate environment conda
env, meaning that we have two conda environments in the image:baseandenv. To my understanding, there is no reason why we need to create a encapsulated environment inside the container. We could just use thebaseenvironment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes several Conda environment YAML files and refactors the command construction in the
runmethod ofprocessor/tasks/CROWNMain.pyto usewrap_executable_command.