fix: correlate SSE traces and cancellation - #13
Draft
KDB-Wind wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
traceIdalongsidetaskIdthrough SSE meta events and lifecycle logsCANCELLED, including cancellation-before-handle racesWhy
The Better Harness reassessment found that a maintainer could not reliably correlate SSE stage failures, cancellation cleanup, and the final trace outcome. The cancellation path also bypassed trace finalization, allowing runs to remain
RUNNING.Validation
./mvnw -B -ntp -pl bootstrap -am -Dtest=StreamChatTraceRunnerTest,StreamChatPipelineTest -Dsurefire.failIfNoSpecifiedTests=false test./mvnw -B -ntp spotless:check verifycd frontend && npm run test -- src/hooks/__tests__/useStreamResponse.test.tscd frontend && npm run lint && npm run test:coverage && npm run buildAll passed locally. This PR intentionally does not run real integration infrastructure, dismiss alerts, change rulesets, trigger AI review, or merge itself.
External follow-up
Real integration runs, staging credential validation, secret rotation, database migration, default-branch alert disposition, and longitudinal task evidence remain documented in
docs/external-governance-operations.md.