fix: ship kernel headers in wheels so @Thread works after pip (0.2.1) - #29
Merged
Merged
Conversation
PyPI 0.2.0 installs could not JIT @thread: shared_host.hpp lived only in the monorepo cpp/ tree and build.py skipped missing includes silently. Bundle headers + sync_bridge under cthreads/_native, resolve that path first, and fail loud if neither layout exists. Add unit/integration regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pip install cthreads/cthreads-gpu(0.2.0) could not compile@Threadkernels,shared_host.hppwas never in the wheel. Editablecheckouts still worked, so CI/local hid it; Colab exposed it.
cpp/headers+runtime/sync_bridge.cppintocthreads/_native/.build.pyprefers that layout, then monorepocpp/,and raises if neither exists (no silent skip).
project.versionto 0.2.1 (CPU + GPU wheels share it).Why this is real (not a Colab quirk)
Generated kernels always
#include "shared_host.hpp". Oldbuild.pyonlylooked at
…/cpp/headersrelative to the monorepo layout and didif dir.exists(): add include. On a wheel that path is absent ->includeomitted -> cryptic missing-header compile error. Details:
docs/internals/kernel_build_headers.md(if present on branch) / this PR diff.