CHANGELOG 1.12.1: correct the pull request count - #1738
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1.12.1 intro line said 95 pull requests, 82 of them from contributors. The count was kept by hand across the notes PRs and drifted: #1724 was counted as a contributor PR, and #1737 merged after the line was written.
Recounted from the merge commits in
v1.12.0..dev, with each PR's author from the API: 96 pull requests that change code or docs, 80 of them from contributors, 16 from the maintainer. The ten release-notes PRs and the two docs PRs that went tomaindirectly are not counted. The published v1.12.1 Release already uses 96 and 80. This makes the CHANGELOG agree with it.