docs: clarify documentation and typo fixes are welcome - #1575
Closed
cyberspace-cs wants to merge 3 commits into
Closed
cyberspace-cs wants to merge 3 commits into
cyberspace-cs wants to merge 3 commits into
Conversation
…OTICE The LICENSE file still carried the Apache 2.0 template placeholders (Copyright [yyyy] [name of copyright owner]), so the notice was never actually applied to this work. Fill it in, add the NOTICE file Apache 2.0 expects for the copyright line, and point the four READMEs at both.
license: name the copyright holder and add NOTICE
Note that docs fixes, typo corrections, and translated README improvements do not require opening an experiment issue first.
Owner
|
Thank you for this. The copyright line, the NOTICE file and the license header hunks are already on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The contributing section focuses on benchmark experiments and opening an experiment issue, which may give the impression that every contribution requires an experiment issue. This adds a sentence clarifying that documentation fixes, typo corrections, and improvements to the translated READMEs are always welcome and do not require opening an experiment issue first.
What changed
Verification