Repository navigation
fix(glm53): initialise the two Mat fields #1462 added, so #1458's cleanup holds - #1463
Merged
Merged
Conversation
…anup holds #1458 silenced -Wmissing-field-initializers on the three expert_mats initialisers by naming the `vk` field. #1462 landed alongside it and gave Mat two more trailing fields, `resident` and `metal`, so the warning did not go away, it moved: glm53.c:1411:11: warning: missing initializer for field 'resident' of 'Mat' The zero the compiler was already supplying is the right value -- a streamed expert slot is not resident and has no Metal tensor -- so this only says so explicitly. glm53 now builds clean under -Wextra again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1458 silenced
-Wmissing-field-initializerson the threeexpert_matsinitialisers by naming thevkfield. #1462 landed alongside it and gaveMattwo more trailing fields,residentandmetal, so the warning did not go away, it moved toresident.The zero the compiler was already supplying is the right value: a streamed expert slot is not resident and has no Metal tensor. This only says so explicitly. glm53 builds clean under
-Wextraagain; verified locally.