Repository navigation
fix(tests): the qwen36 fill-wait test needs compat.h to build on Windows - #1459
Merged
Merged
Conversation
dev went red on `Windows UCRT64` / `make check` right after #1390 landed: tests/test_qwen36_tier_fill_wait.c:42:5: error: implicit declaration of function 'setenv'; did you mean 'getenv'? MinGW has no setenv. The tests that include an engine .c inherit compat.h through it, but this one includes qwen36_tier.c, which does not pull it in, so the declaration was never there. Linux never noticed because glibc has setenv, and modern GCC turns an implicit declaration into an error rather than a warning, so the Windows leg is where it surfaced. Same shape as #1440, which added the include to the six tests that already had it. Reproduced and fixed against mingw-w64 with the Makefile's own Windows flags plus -Werror=implicit-function-declaration, then every other gated test was cross-compiled the same way: this file is the only one affected. The three that still fail that sweep (test_uring, test_deepseek_v4, test_v4_ownership) are in TEST_EXCLUDE and are not built on the Windows leg at all. compat.h joins the rule's prerequisites too, so editing the shim relinks the test instead of leaving a stale one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devis red onWindows UCRT64/make checksince #1390 landed:MinGW has no
setenv. Tests that include an engine.cinheritcompat.hthrough it; this one includesqwen36_tier.c, which does not. Linux never noticed because glibc hassetenv, and modern GCC makes an implicit declaration an error rather than a warning, so the Windows leg is where it surfaced. Same shape as #1440.Reproduced locally against mingw-w64 with the Makefile's own Windows flags plus
-Werror=implicit-function-declaration, fixed, then every gated test was cross-compiled the same way: this file is the only one affected. The three that still fail that sweep (test_uring,test_deepseek_v4,test_v4_ownership) are inTEST_EXCLUDEand are not built on the Windows leg.compat.halso joins the rule's prerequisites, so editing the shim relinks the test.