Repository navigation
fix: enable qwen36 GPU tier when building with HIP=1 - #1454
Conversation
The invite in the READMEs and the site returns "Invite is expired" (Discord API code 50270), so every Discord link we publish is currently dead: 4 READMEs plus site/index.html, 2 occurrences each. Replaces MAaKtQRc with FkyrEeJR across all 10.
docs: replace the expired Discord invite (all 4 READMEs + site)
Release 1.10.2
HIP=1 still linked backend_cuda.o into qwen36 but used NOCUDA_LDFLAGS, which dropped -lstdc++ and caused a link failure on Linux ROCm builds. Mirror the CUDA=1 branch so HIP builds also compile qwen36_tier.c and link with the full LDFLAGS set.
|
Retargeted from |
|
The |
|
@JustVugg thanks for clarifying, I will be more mindful in the next PRs. Thank you so much for merging as well. |
Summary
make -C c qwen36 HIP=1on Linux ROCm: the target linkedbackend_cuda.obut still usedNOCUDA_LDFLAGS, which dropped-lstdc++and failed at link time withDSO missing from command line.CUDA=1branch so HIP builds also compileqwen36_tier.cand link with the fullCFLAGS/LDFLAGSset (including-DCOLI_CUDA,-lamdhip64, and-lstdc++).Problem
The qwen36 Makefile switch only treated
CUDA=1as a GPU build. WithHIP=1,$(CUDA_OBJ)(includingbackend_cuda.o) is still linked intoqwen36, but the build fell through to the CPU-only branch:QWEN36_LDFLAGS = $(NOCUDA_LDFLAGS)— no-lstdc++/ HIP runtime flagsQWEN36_TIER_SRCempty — GPU expert tier not compiledRepro (Linux + ROCm):
Code changes assisted by Cursor.