Skip to content

fix: enable qwen36 GPU tier when building with HIP=1 - #1454

Merged
JustVugg merged 4 commits into
JustVugg:devfrom
yuripourre:fix/qwen36-hip-tier
Sep 13, 2026
Merged

JustVugg merged 4 commits into
JustVugg:devfrom
yuripourre:fix/qwen36-hip-tier

Conversation

@yuripourre

Copy link
Copy Markdown
Contributor

Summary

  • Fix make -C c qwen36 HIP=1 on Linux ROCm: the target linked backend_cuda.o but still used NOCUDA_LDFLAGS, which dropped -lstdc++ and failed at link time with DSO missing from command line.
  • Mirror the existing CUDA=1 branch so HIP builds also compile qwen36_tier.c and link with the full CFLAGS/LDFLAGS set (including -DCOLI_CUDA, -lamdhip64, and -lstdc++).

Problem

The qwen36 Makefile switch only treated CUDA=1 as a GPU build. With HIP=1, $(CUDA_OBJ) (including backend_cuda.o) is still linked into qwen36, but the build fell through to the CPU-only branch:

  • QWEN36_LDFLAGS = $(NOCUDA_LDFLAGS) — no -lstdc++ / HIP runtime flags
  • QWEN36_TIER_SRC empty — GPU expert tier not compiled

Repro (Linux + ROCm):

make -C c qwen36 HIP=1 HIP_ARCH=gfx1201 HIPCC=/usr/bin/hipcc

Code changes assisted by Cursor.

JustVugg and others added 4 commits September 6, 2026 01:22
The invite in the READMEs and the site returns "Invite is expired"
(Discord API code 50270), so every Discord link we publish is currently
dead: 4 READMEs plus site/index.html, 2 occurrences each.

Replaces MAaKtQRc with FkyrEeJR across all 10.
docs: replace the expired Discord invite (all 4 READMEs + site)
HIP=1 still linked backend_cuda.o into qwen36 but used NOCUDA_LDFLAGS,
which dropped -lstdc++ and caused a link failure on Linux ROCm builds.
Mirror the CUDA=1 branch so HIP builds also compile qwen36_tier.c and
link with the full LDFLAGS set.
@JustVugg
JustVugg changed the base branch from main to dev September 12, 2026 22:24
@JustVugg

Copy link
Copy Markdown
Owner

Retargeted from main to dev. Every change lands on dev first; main only moves on a release, and it is protected, which is why the checks showed as blocked. Nothing to do on your side, the branch and the diff are unchanged.

@JustVugg

Copy link
Copy Markdown
Owner

The Linux failure here (expert did not become resident during warmstart, in test_qwen36_tier_multidev) is not yours. Your run was built against a dev snapshot taken in the middle of a merge sequence that landed #1390 and #1388, and #1388 changes assertions in that exact test. Both tests pass on settled dev (six consecutive runs of test_qwen36_tier_multidev, five of test_qwen36_tier_fill_wait). I have re-run the failed jobs against current dev. Nothing to change on your side; the four Makefile lines are the right shape.

@JustVugg
JustVugg merged commit fc590c8 into JustVugg:dev Sep 13, 2026
30 of 31 checks passed
@JustVugg JustVugg mentioned this pull request Sep 13, 2026
@yuripourre

Copy link
Copy Markdown
Contributor Author

@JustVugg thanks for clarifying, I will be more mindful in the next PRs.

Thank you so much for merging as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants