Repository navigation
Clipping filter: skip models with no data, state its limits - #12
Merged
Merged
Conversation
- A model that returns no weather (outside its area) came out of pv() as 0 and pulled down the forecast used to find clipped hours (and the outage filter). Its hours are now NaN and left out of the mean. - Log a line when clip_limit_kw is set but no day-ahead forecast was available, and count n_hours after the outage and clipping masks. - README: replace "forecast error does not bias the level" with what was measured. On a roof that never clips, dropping the top 20 % of hours gave 0.89 against a true 0.90 when picked on the forecast, 0.79 when picked on the measured value. Say that a very noisy forecast still leaves some bias, that the threshold uses start_efficiency, and that the filtered hours also leave band_coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10, after a second review of the clipping filter.
pv()as 0 and pulled down the forecast used to pick clipped hours. In the test, g fell from 0.900 to 0.883. Those hours are now NaN and skipped in the mean. The outage filter reads the same mean, so it benefits too.The forecast side stays within about 2 % of the full-sample value up to 30 % of hours dropped. The README now gives these numbers and the two limits: very noisy forecasts, and a threshold that uses
start_efficiency.n_hoursis counted after the masks.Tests: one new test (a model with no data must not change g), which fails without the fix. Full suite: 93 pass on Python 3.12 locally.