Repository navigation
Update test dependencies (Playwright 1.64.1, Python 3.12) - #1155
Merged
CGBassPlayer merged 4 commits intoNov 11, 2026
Merged
CGBassPlayer merged 4 commits into
CGBassPlayer merged 4 commits into
Conversation
CGBassPlayer
marked this pull request as ready for review
November 7, 2026 03:00
CGBassPlayer
changed the base branch from
develop
to
feature/e2e-test-expansion
November 9, 2026 02:43
CGBassPlayer
changed the base branch from
feature/e2e-test-expansion
to
develop
November 9, 2026 02:46
This was referenced Nov 9, 2026
Merged
Playwright 1.64.1, pinned package versions, Python 3.12 (latest pipenv needs >=3.11), noble Playwright image and pinned pipenv.
…rovides base_url pytest-playwright 0.10 no longer installs pytest-base-url, so the import stopped the suite from loading.
The ./Dockerfile.tests and ./tests/Pipfile.lock path filters never matched, so the image never rebuilt on dependency changes. Also checkout v7, buildah-build v3, push-to-registry v3, and $GITHUB_OUTPUT instead of ::set-output.
pytest-playwright 0.10's fallback base_url fixture is a class method, which pytest 9.2 deprecates; the base-url extra (pytest-base-url) replaces it. Set pip env vars so the root image skips the root-user and version-check notices.
CGBassPlayer
force-pushed
the
chore/test-deps-upgrade
branch
from
November 11, 2026 02:32
00da303 to
2a57c64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Merge after #475. This branch is built on top of #475 so every new test was verified against the new dependencies. Until #475 merges, this diff also shows #475's commits; only the last 4 commits belong to this PR.
Summary of the Changes
mcr.microsoft.com/playwright/pythonv1.50.0-jammy→v1.64.1-noble(Python 3.10 → 3.12)2023.7.23→2026.10.5(current pipenv needs Python ≥ 3.11)test/Pipfile, now pinned with==, lock regenerated):playwright1.50.0 → 1.64.1pytest-playwright0.7.0 → 0.10.0pytest8.3.5 → 9.2.0pytest-xdist3.6.1 → 3.8.0pytest-metadata3.1.1 (now pinned)black25.1.0 → 26.10.1,pylint3.3.5 → 4.1.3test/conftest.py: removed thepytest_base_urlimport.pytest-playwright0.10 no longer installspytest-base-urland provides thebase_urlfixture itself, so the import stopped the suite from loading.build_container-tests.yml:pathsfilter../Dockerfile.testsand./tests/Pipfile.locknever matched (GitHub path filters don't take./, and the folder istest/), so the published test image was never rebuilt when dependencies changed. It now watchesDockerfile.tests,test/Pipfile,test/Pipfile.lockand the workflow itself.actions/checkoutv2 → v7,redhat-actions/buildah-buildv2 → v3,redhat-actions/push-to-registryv2 → v3::set-outputwith$GITHUB_OUTPUTTesting
Run the same way CI does (
docker compose up --build, thenpytest --base-url http://jb-com) on the new image, on top of #475:-m 'not periodic': 965 passed, 3 skipped, 8 xfailed (same result as E2E Test Expansion #475 on the old dependencies)-m periodic: 1 passedNotes
build_container-tests.ymlonly runs on pushes tomain/developwith registry secrets, so it couldn't be run from this PR. It passesactionlint.push-to-registryv3 keeps tag case, so the date tag now keeps its uppercaseT(e.g.tests-develop-2026-11-06T21_45_00-05_00).buildah-buildv3 squashes images by default.PytestRemovedIn10Warningfrompytest-playwright's own built-inbase_urlfixture. It's harmless for now and comes from the plugin, not this repo.