Skip to content

Fix argument order in std::aligned_alloc calls #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaoyihao wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix argument order in std::aligned_alloc calls #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions junction/new_override.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,14 @@ __always_inline void *do_new_aligned(size_t size, std::align_val_t a) {
auto align = static_cast<size_t>(a);

// Handle the case where the runtime is not initialized
if (unlikely(!runtime.ready)) return std::aligned_alloc(size, align);
if (unlikely(!runtime.ready)) return std::aligned_alloc(align, size);

size_t aligned = AlignUp(size, align);

// Handle the case where the object being allocated is large
if (unlikely(aligned >= kMaxAllocSize)) {
rt::RuntimeLibcGuard guard;
return std::aligned_alloc(size, align);
return std::aligned_alloc(align, size);
}

// Hot path: Handle typical allocations using the runtime
Expand Down