fix (UnusedLiveViewAssign): Recognize piped Map.get/{2,3} as a read - #28
Merged
Conversation
s3cur3
enabled auto-merge (squash)
July 28, 2026 17:30
s3cur3
force-pushed
the
ty/unused-assigns-map-read
branch
from
July 28, 2026 17:34
be40d74 to
1c8654d
Compare
This fixes an oversight in the previous implementation where we didn't recognize `Map.get/{2,3}` calls as a read from `assigns` when they were part of a pipe chain.
s3cur3
force-pushed
the
ty/unused-assigns-map-read
branch
from
July 28, 2026 17:37
1c8654d to
5197a71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an oversight in the previous implementation where we didn't recognize
Map.get/{2,3}calls as a read fromassignswhen they were part of a pipe chain.