Skip to content

ci: add commitlint checks#206

Closed
MilesCranmerBot wants to merge 1 commit into
JuliaPhysics:mainfrom
MilesCranmerBot:ci/commitlint
Closed

ci: add commitlint checks#206
MilesCranmerBot wants to merge 1 commit into
JuliaPhysics:mainfrom
MilesCranmerBot:ci/commitlint

Conversation

@MilesCranmerBot

Copy link
Copy Markdown
Contributor

Summary

  • add a minimal commitlint config
  • lint both PR titles and PR commits in CI

This uses commitlint directly: PR titles are checked with npx commitlint, and commits are checked with wagoid/commitlint-github-action.

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1.10)

Time benchmarks
main fa75e9a... main / fa75e9a...
Quantity/creation/Quantity(x) 2.32 ± 0.003 ns 2.6 ± 0.002 ns 0.892 ± 0.0013
Quantity/creation/Quantity(x, length=y) 2.61 ± 0.005 ns 2.32 ± 0.005 ns 1.12 ± 0.0032
Quantity/with_numbers/*real 2.32 ± 0.004 ns 2.32 ± 0.004 ns 1 ± 0.0024
Quantity/with_numbers/^int 7.5 ± 2 ns 7.49 ± 2 ns 1 ± 0.38
Quantity/with_numbers/^int * real 7.51 ± 2.3 ns 7.5 ± 2 ns 1 ± 0.41
Quantity/with_quantity/+y 3.76 ± 0.022 ns 3.76 ± 0.023 ns 1 ± 0.0085
Quantity/with_quantity//y 2.61 ± 0.005 ns 2.61 ± 0.002 ns 1 ± 0.0021
Quantity/with_self/dimension 2.03 ± 0.003 ns 2.32 ± 0.004 ns 0.876 ± 0.002
Quantity/with_self/inv 2.61 ± 0.004 ns 2.33 ± 0.007 ns 1.12 ± 0.0038
Quantity/with_self/ustrip 2.03 ± 0.003 ns 2.03 ± 0.004 ns 1 ± 0.0025
QuantityArray/broadcasting/multi_array_of_quantities 0.147 ± 0.0064 ms 0.149 ± 0.0049 ms 0.983 ± 0.054
QuantityArray/broadcasting/multi_normal_array 0.0571 ± 0.00099 ms 0.0491 ± 0.0022 ms 1.16 ± 0.057
QuantityArray/broadcasting/multi_quantity_array 0.165 ± 0.0078 ms 0.168 ± 0.0079 ms 0.981 ± 0.066
QuantityArray/broadcasting/x^2_array_of_quantities 27.5 ± 7.5 μs 25.9 ± 5.5 μs 1.06 ± 0.37
QuantityArray/broadcasting/x^2_normal_array 5.99 ± 2.3 μs 6.66 ± 2 μs 0.9 ± 0.44
QuantityArray/broadcasting/x^2_quantity_array 7.28 ± 1.2 μs 7.39 ± 1.4 μs 0.985 ± 0.25
QuantityArray/broadcasting/x^4_array_of_quantities 0.0853 ± 0.0064 ms 0.0855 ± 0.0052 ms 0.998 ± 0.097
QuantityArray/broadcasting/x^4_normal_array 0.0512 ± 0.00088 ms 0.0484 ± 0.00092 ms 1.06 ± 0.027
QuantityArray/broadcasting/x^4_quantity_array 0.0541 ± 0.00072 ms 0.0484 ± 0.00083 ms 1.12 ± 0.024
time_to_load 0.194 ± 0.0018 s 0.195 ± 0.00053 s 0.995 ± 0.0097
Memory benchmarks
main fa75e9a... main / fa75e9a...
Quantity/creation/Quantity(x) 0 allocs: 0 B 0 allocs: 0 B
Quantity/creation/Quantity(x, length=y) 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/*real 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/^int 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/^int * real 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_quantity/+y 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_quantity//y 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/dimension 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/inv 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/ustrip 0 allocs: 0 B 0 allocs: 0 B
QuantityArray/broadcasting/multi_array_of_quantities 2 allocs: 0.382 MB 2 allocs: 0.382 MB 1
QuantityArray/broadcasting/multi_normal_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
QuantityArray/broadcasting/multi_quantity_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
QuantityArray/broadcasting/x^2_array_of_quantities 2 allocs: 0.382 MB 2 allocs: 0.382 MB 1
QuantityArray/broadcasting/x^2_normal_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
QuantityArray/broadcasting/x^2_quantity_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
QuantityArray/broadcasting/x^4_array_of_quantities 2 allocs: 0.382 MB 2 allocs: 0.382 MB 1
QuantityArray/broadcasting/x^4_normal_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
QuantityArray/broadcasting/x^4_quantity_array 2 allocs: 0.0763 MB 2 allocs: 0.0763 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@github-actions

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1)

Time benchmarks
main fa75e9a... main / fa75e9a...
Quantity/creation/Quantity(x) 3.1 ± 0.01 ns 3.1 ± 0.01 ns 1 ± 0.0046
Quantity/creation/Quantity(x, length=y) 3.42 ± 0.001 ns 3.42 ± 0.01 ns 1 ± 0.0029
Quantity/with_numbers/*real 2.79 ± 0.001 ns 3.42 ± 0.01 ns 0.818 ± 0.0024
Quantity/with_numbers/^int 12.1 ± 0.99 ns 12.4 ± 1.3 ns 0.977 ± 0.13
Quantity/with_numbers/^int * real 11.9 ± 1 ns 12.1 ± 1.3 ns 0.985 ± 0.14
Quantity/with_quantity/+y 4.04 ± 0.01 ns 4.05 ± 0.04 ns 0.998 ± 0.01
Quantity/with_quantity//y 3.42 ± 0.01 ns 3.42 ± 0.01 ns 1 ± 0.0041
Quantity/with_self/dimension 2.79 ± 0 ns 2.79 ± 0 ns 1 ± 0
Quantity/with_self/inv 3.42 ± 0.011 ns 3.42 ± 0.01 ns 1 ± 0.0044
Quantity/with_self/ustrip 2.79 ± 0.009 ns 3.1 ± 0.01 ns 0.9 ± 0.0041
QuantityArray/broadcasting/multi_array_of_quantities 0.112 ± 0.0018 ms 0.112 ± 0.0038 ms 1 ± 0.038
QuantityArray/broadcasting/multi_normal_array 0.0471 ± 0.00024 ms 0.0497 ± 0.00029 ms 0.948 ± 0.0074
QuantityArray/broadcasting/multi_quantity_array 0.0559 ± 0.006 ms 0.0501 ± 0.00057 ms 1.12 ± 0.12
QuantityArray/broadcasting/x^2_array_of_quantities 25.3 ± 6.8 μs 23.1 ± 7.1 μs 1.09 ± 0.44
QuantityArray/broadcasting/x^2_normal_array 4.07 ± 2 μs 2.33 ± 1.4 μs 1.74 ± 1.3
QuantityArray/broadcasting/x^2_quantity_array 3.66 ± 0.98 μs 3.49 ± 0.17 μs 1.05 ± 0.29
QuantityArray/broadcasting/x^4_array_of_quantities 0.0814 ± 0.00069 ms 0.0814 ± 0.0011 ms 1 ± 0.016
QuantityArray/broadcasting/x^4_normal_array 0.0435 ± 0.00018 ms 0.0435 ± 0.00019 ms 1 ± 0.006
QuantityArray/broadcasting/x^4_quantity_array 0.0437 ± 0.00018 ms 0.0436 ± 0.00018 ms 1 ± 0.0059
time_to_load 0.191 ± 0.0018 s 0.187 ± 0.0013 s 1.02 ± 0.012
Memory benchmarks
main fa75e9a... main / fa75e9a...
Quantity/creation/Quantity(x) 0 allocs: 0 B 0 allocs: 0 B
Quantity/creation/Quantity(x, length=y) 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/*real 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/^int 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_numbers/^int * real 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_quantity/+y 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_quantity//y 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/dimension 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/inv 0 allocs: 0 B 0 allocs: 0 B
Quantity/with_self/ustrip 0 allocs: 0 B 0 allocs: 0 B
QuantityArray/broadcasting/multi_array_of_quantities 3 allocs: 0.382 MB 3 allocs: 0.382 MB 1
QuantityArray/broadcasting/multi_normal_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
QuantityArray/broadcasting/multi_quantity_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
QuantityArray/broadcasting/x^2_array_of_quantities 3 allocs: 0.382 MB 3 allocs: 0.382 MB 1
QuantityArray/broadcasting/x^2_normal_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
QuantityArray/broadcasting/x^2_quantity_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
QuantityArray/broadcasting/x^4_array_of_quantities 3 allocs: 0.382 MB 3 allocs: 0.382 MB 1
QuantityArray/broadcasting/x^4_normal_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
QuantityArray/broadcasting/x^4_quantity_array 3 allocs: 0.0764 MB 3 allocs: 0.0764 MB 1
time_to_load 0.145 k allocs: 11 kB 0.145 k allocs: 11 kB 1

@codecov

codecov Bot commented Mar 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.15%. Comparing base (3246758) to head (fa75e9a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          23       23           
  Lines        1301     1301           
=======================================
  Hits         1290     1290           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant