Repository navigation
Deprecate user_ctx and two utilities; guard star_fd_coloring - #324
Merged
Merged
Conversation
user_ctx, set_user_ctx! and callbacks that take a trailing context now warn and go in v0.6: a closure carries the context. The VTKtensor merge and create_split_boundary_labels! warn too, and copies are in the examples. star_fd_coloring throws an ArgumentError for a DMDA that is not 2-D with a STAR stencil, where a BOX stencil gave a coloring that leaves out entries. Assisted-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
user_ctx, set_user_ctx! and callbacks that take a trailing context now warn and go in v0.6: a closure carries the context. The VTKtensor merge and create_split_boundary_labels! warn too, and copies are in the examples. star_fd_coloring throws an ArgumentError for a DMDA that is not 2-D with a STAR stencil, where a BOX stencil gave a coloring that leaves out entries.
Assisted-by: Claude Sonnet 5.5 noreply@anthropic.com