Repository navigation
Tests: no PETSc traceback from the callbacks that fail on purpose - #299
Merged
Merged
Conversation
without_petsc_traceback pushes PETSc's return-only error handler around the four solves in pc.jl and snes.jl that check how a failing callback surfaces. The CI log printed a traceback for each of them, once per scalar type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four tests make a callback throw, or return a nonzero code, on purpose. They check that
ksp \ bandsolve!rethrow the exception, and that a rawLibPETSccall fails with aPetscError. PETSc printed a full traceback for each one, and CI does that once per scalar type, so a passing run showed 16PETSC ERRORblocks that looked like failures.without_petsc_traceback(f, petsclib)intest/testutils.jlpushesPetscReturnErrorHandleraround those calls, then pops it. The calls fail exactly as before; only the printout goes.runtests.jlnow includestestutils.jlonce at the top, and the two test files include it themselves when run on their own.It's just a bit more tidy