[HYPRE64] Install headers under include/HYPRE64#13948
Open
ViralBShah wants to merge 3 commits into
Open
Conversation
Stock HYPRE_jll installs the same header names into ${includedir} --
notably HYPRE_config.h, which records the integer width (HYPRE_BIGINT)
-- so HYPRE_jll and HYPRE64_jll were not co-installable without one
silently shadowing the other in the prefix merge. Move HYPRE64's
headers into their own include/HYPRE64/ subdirectory.
Motivation: PETSc (#13691) builds 64-bit-PetscInt variants against
HYPRE64_jll and 32-bit ones against HYPRE_jll in the same build
prefix; with this change it can pass
--with-hypre-include=${includedir}/HYPRE64 or ${includedir} per
variant instead of staging sed-patched header copies.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stock HYPRE_jll installs the same header names into
${includedir}— notablyHYPRE_config.h, which records the integer width (HYPRE_BIGINT) — so HYPRE_jll and HYPRE64_jll were not co-installable: in a prefix with both, one config header silently shadows the other.This moves HYPRE64's headers into their own
include/HYPRE64/subdirectory.Motivation: PETSc (#13691) builds its 64-bit-PetscInt variants against HYPRE64_jll and the 32-bit ones against HYPRE_jll in the same build prefix; with this change it can pass
--with-hypre-include=${includedir}/HYPRE64(or plain${includedir}) per variant instead of staging sed-patched header copies. The PETSc recipe will be updated accordingly once this ships; HYPRE64_jll currently has no other consumers.🤖 Generated with Claude Code