[SuperLU_DIST] Ship per-integer-width header copies#13947
Open
ViralBShah wants to merge 1 commit into
Open
Conversation
Both the Int32 and Int64 builds install their headers into
${includedir}, so the second build overwrites the first's
superlu_dist_config.h and the shipped XSDK_INDEX_SIZE only matches one
of the two libraries. Keep self-contained copies of the headers under
include/superlu_dist_Int32/ and include/superlu_dist_Int64/ so
consumers that must match a specific index width (e.g. PETSc, which
links libsuperlu_dist_Int32 for its 32-bit-PetscInt variants) can
point at the right set. The ambiguous top-level headers stay as
before for backward compatibility.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ViralBShah
force-pushed
the
vs/superlu-dist-per-width-headers
branch
from
57f609a to
bcdbdf2
Compare
auto-merge was automatically disabled
June 12, 2026 18:05
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the Int32 and Int64 builds install their headers into
${includedir}, so the second build overwrites the first'ssuperlu_dist_config.hand the shippedXSDK_INDEX_SIZEonly matches one of the two libraries (currently the Int64 one).This keeps self-contained copies under
include/superlu_dist_Int32/andinclude/superlu_dist_Int64/so consumers that must match a specific index width can point at the right set. The top-level headers stay as before for backward compatibility.Motivation: PETSc (#13691) builds both Int64- and Int32-
PetscIntvariants and links the matchinglibsuperlu_dist_*; today its recipe has to stage sed-patched header copies to get a consistentint_t. With this change it can simply use--with-superlu_dist-include=${includedir}/superlu_dist_Int${N}.🤖 Generated with Claude Code