[KrakenFortran] Add JLL for KrakenFortran#13836
Open
vardister wants to merge 2 commits into
Open
Conversation
imciner2
reviewed
Jun 5, 2026
| FFLAGS="-cpp -fPIC -O3 -finline-functions -fno-strength-reduce -fomit-frame-pointer -falign-functions=2" | ||
|
|
||
| # Compile all source files in the correct order for modules | ||
| gfortran $FFLAGS -c ../krakmod.f90 -o krakmod.o |
Member
There was a problem hiding this comment.
I would suggest you move all of this into the source directory of the upstream repository in a simple build system (e.g., this looks like it could be a simple CMake file).
That way the Yggdrasil recipe is more decoupled from the actual source code and is easier to read.
Author
There was a problem hiding this comment.
I followed your instructions and moved all of it to a CMake file in the source repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am building a package that calls FORTRAN code through shared libraries using julia bindings. The FORTRAN code is a known normal-mode algorithm for underwater acoustics modeling.
I hope everything is in order with this pull request.