Repository navigation
Conversation
This was referenced Sep 28, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
@pkgeval runtests() |
Member
Author
|
@nanosoldier runbenchmarks() |
vchuravy
force-pushed
the
vc/effects-4-string-ptr-effects
branch
from
September 29, 2026 12:19
7408486 to
57c5123
Compare
|
@vchuravy: run Full report: https://pkgeval-reports.julialang.org/?run=gh-5884395480 |
vchuravy
force-pushed
the
vc/effects-4-string-ptr-effects
branch
2 times, most recently
from
October 5, 2026 05:40
7b5e657 to
086d3bf
Compare
`unsafe_convert(::Type{Ptr{UInt8}}, ::String)` was a plain foreigncall
and therefore EFFECTS_UNKNOWN, which made every String primitive built on
`pointer(s)` (`codeunit`, `isascii`, `nextind`, ...) lose :nothrow,
:notaskstate and :inaccessiblememonly even though `GC.@preserve` itself
is effect-transparent. `jl_string_ptr` is pure pointer arithmetic on the
object; it is not :consistent because egal strings have distinct
addresses. Adds a bootstrap `@_total_notconsistent_meta` since
`@assume_effects` is not available yet in essentials.jl.
Assisted-by: Claude Code (Fable 5.1)
vchuravy
force-pushed
the
vc/effects-4-string-ptr-effects
branch
from
October 5, 2026 10:27
086d3bf to
ebe24d1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth of a 4-PR stack (#63462 → #63463 → #63464 → #63465). Independent of the others in content — it only sits on top so PkgEval on this PR covers the whole stack — and can be rebased onto master and merged on its own.
unsafe_convert(::Type{Ptr{UInt8}}, ::String)is a plain foreigncall and thereforeEFFECTS_UNKNOWN, which makes every String primitive built onpointer(s)(codeunit,isascii,nextind, …) lose:nothrow,:notaskstateand:inaccessiblememonlyeven thoughGC.@preserveitself is effect-transparent.jl_string_ptris pure pointer arithmetic on the object; it is not:consistentbecause egal strings have distinct addresses.Adds a bootstrap
@_total_notconsistent_meta(like@_total_meta, minus:consistent) since@assume_effectsis not available yet inessentials.jl.Before/after:
(
!mremains becausepointerrefis defined withinaccessiblememonly = ALWAYS_FALSE.)🤖 Generated with Claude Code