Skip to content

[backports-release-1.11] Revert "Make late gc lower handle insertelement of alloca use. (#58637)"#59447

Closed
DilumAluthge wants to merge 1 commit into
backports-release-1.11from
dpa/revert-47d905d---backports-release-1.11
Closed

[backports-release-1.11] Revert "Make late gc lower handle insertelement of alloca use. (#58637)"#59447
DilumAluthge wants to merge 1 commit into
backports-release-1.11from
dpa/revert-47d905d---backports-release-1.11

Conversation

@DilumAluthge

@DilumAluthge DilumAluthge commented Aug 31, 2025

Copy link
Copy Markdown
Member

This reverts commit 47d905d (which backports #58637 to 1.11).

Targets backports-release-1.11 (#59336).

Motivation

Let's see if this fixes the llvmpasses CI job on backports-release-1.11 (#59336).

@DilumAluthge DilumAluthge changed the title Revert "Make late gc lower handle insertelement of alloca use. (#58637)" [backports-release-1.11] Revert "Make late gc lower handle insertelement of alloca use. (#58637)" Aug 31, 2025
@DilumAluthge

Copy link
Copy Markdown
Member Author

cc: @gbaraldi @vtjnash @serenity4

@DilumAluthge

DilumAluthge commented Aug 31, 2025

Copy link
Copy Markdown
Member Author

Hmmm. This doesn't seem to fix the llvmpasses CI failure.

@DilumAluthge DilumAluthge deleted the dpa/revert-47d905d---backports-release-1.11 branch August 31, 2025 02:25
@DilumAluthge DilumAluthge restored the dpa/revert-47d905d---backports-release-1.11 branch August 31, 2025 18:36
@DilumAluthge DilumAluthge reopened this Aug 31, 2025
@DilumAluthge

DilumAluthge commented Aug 31, 2025

Copy link
Copy Markdown
Member Author

This is definitely the first bad commit, but a simple revert doesn't seem sufficient to fix CI.

@DilumAluthge DilumAluthge force-pushed the dpa/revert-47d905d---backports-release-1.11 branch from a1f3393 to 53a0059 Compare August 31, 2025 18:38
@DilumAluthge

Copy link
Copy Markdown
Member Author

@gbaraldi Would you happen to know what's going on here?

@DilumAluthge

DilumAluthge commented Aug 31, 2025

Copy link
Copy Markdown
Member Author

Okay, I rebased this PR, and now this PR does indeed fix the llvmpasses CI job.

@DilumAluthge DilumAluthge marked this pull request as ready for review August 31, 2025 19:21
@DilumAluthge DilumAluthge added the release Release management and versioning. label Aug 31, 2025
@DilumAluthge DilumAluthge force-pushed the dpa/revert-47d905d---backports-release-1.11 branch from 53a0059 to 4f6f2ef Compare September 1, 2025 13:17
@DilumAluthge DilumAluthge mentioned this pull request Sep 1, 2025
65 tasks
@DilumAluthge

Copy link
Copy Markdown
Member Author

Closed in favor of b04078d

@DilumAluthge DilumAluthge deleted the dpa/revert-47d905d---backports-release-1.11 branch September 1, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Release management and versioning.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant