Add bfloat LLVM fix to 1.11 by gbaraldi · Pull Request #57874 · JuliaLang/julia

gbaraldi · 2025-03-24T15:09:15Z

No description provided.

KristofferC · 2025-03-24T15:18:21Z

Needs a rebase I think

giordano · 2025-03-24T16:17:37Z

https://buildkite.com/julialang/julia-release-1-dot-11/builds/421#0195c8c0-59a6-4ac7-a50f-d150114395de/715-2243

Message:/usr[buildroot]/usr/bin/../lib/libjulia-internal.so.1.11: Undefined symbol "_ZNSt3__122__libcpp_verbose_abortEPKcz"

@ararslan do we need to upgrade the FreeBSD image here in CI? That'd be relevant also for LLVM 20 and any other new builds

ararslan · 2025-03-24T17:02:18Z

Ah right, yes, since Yggdrasil is building for FreeBSD 13.4 on x86-64 rather than 13.2, we probably need to upgrade Julia CI image from 13.2 to 13.4 as well.

giordano · 2025-03-24T20:22:52Z

FAIL: Julia :: late-lower-gc.ll (11 of 45)
******************** TEST 'Julia :: late-lower-gc.ll' FAILED ********************
Script:
--
: 'RUN: at line 3';   opt -enable-new-pm=1 --opaque-pointers=0 --load-pass-plugin=libjulia-codegen.so -passes='function(LateLowerGCFrame)' -S /cache/build/tester-amdci5-15/julialang/julia-release-1-dot-11/test/llvmpasses/late-lower-gc.ll | FileCheck /cache/build/tester-amdci5-15/julialang/julia-release-1-dot-11/test/llvmpasses/late-lower-gc.ll -check-prefixes=CHECK,TYPED
: 'RUN: at line 5';   opt -enable-new-pm=1 --opaque-pointers=1 --load-pass-plugin=libjulia-codegen.so -passes='function(LateLowerGCFrame)' -S /cache/build/tester-amdci5-15/julialang/julia-release-1-dot-11/test/llvmpasses/late-lower-gc.ll | FileCheck /cache/build/tester-amdci5-15/julialang/julia-release-1-dot-11/test/llvmpasses/late-lower-gc.ll --check-prefixes=CHECK,OPAQUE
--
Exit Code: 2
Command Output (stderr):
--
/cache/build/tester-amdci5-15/julialang/julia-release-1-dot-11/test/llvmpasses/late-lower-gc.ll:137:22: warning: ptr type is only supported in -opaque-pointers mode
    %2 = load float, ptr addrspace(1) %0, align 4, !invariant.load !1
                     ^
opt: /cache/build/tester-amdci5-15/julialang/julia-release-1-dot-11/test/llvmpasses/late-lower-gc.ll:137:22: error: expected type
    %2 = load float, ptr addrspace(1) %0, align 4, !invariant.load !1
                     ^
FileCheck error: '<stdin>' is empty.
FileCheck command line:  FileCheck /cache/build/tester-amdci5-15/julialang/julia-release-1-dot-11/test/llvmpasses/late-lower-gc.ll -check-prefixes=CHECK,TYPED
--
********************

is this related to this PR?

gbaraldi · 2025-03-24T21:06:06Z

No, that is broken on the target branch too

giordano · 2025-03-24T21:12:29Z

Ok, so only problem is the FreeBSD image (which should be fixed anyway because it'll become a problem in the future, but Alex is already on the case)

giordano · 2025-04-01T18:00:50Z

The history here looks messed up now. I think only two most recent commits should be retained, all previous ones can be dropped

giordano · 2025-04-01T18:17:09Z

@ararslan

 clang -m64 -O3 -g -I/usr[buildroot]/src/flisp/../support -std=gnu11 -pipe -fPIC -fno-strict-aliasing -D_FILE_OFFSET_BITS=64  -I/usr[buildroot]/usr/include -I/usr[buildroot]/usr/include -I/usr[buildroot]/usr/include  -DJL_LIBRARY_EXPORTS_INTERNAL -DUTF8PROC_EXPORTS -DUSE_COMPUTED_GOTO -Wall -Wno-strict-aliasing -fvisibility=hidden -Wpointer-arith -Wundef -Wold-style-definition -Wstrict-prototypes -Wc++-compat -Wl,-Bdynamic -L/usr[buildroot]/usr/lib -Wl,-rpath,/usr[buildroot]/usr/lib /usr[buildroot]/src/flisp/flisp.o /usr[buildroot]/src/flisp/builtins.o /usr[buildroot]/src/flisp/string.o /usr[buildroot]/src/flisp/equalhash.o /usr[buildroot]/src/flisp/table.o /usr[buildroot]/src/flisp/iostream.o /usr[buildroot]/src/flisp/julia_extensions.o /usr[buildroot]/src/flisp/flmain.o -o /usr[buildroot]/src/flisp/flisp /usr[buildroot]/src/flisp/libflisp.a /usr[buildroot]/src/flisp/../support/libsupport.a /usr[buildroot]/usr/lib/libuv.a /usr[buildroot]/usr/lib/libutf8proc.a -lpthread -lelf -lkvm -lrt -lpthread -latomic -lgcc_s -Wl,--export-dynamic -Wl,--version-script=/usr[buildroot]/src/julia.expmap -Wl,--no-whole-archive
ld: error: version script assignment of 'JL_LIBJULIA_1.11' to symbol '__stack_chk_guard' failed: symbol not defined
ld: error: version script assignment of 'JL_LIBJULIA_1.11' to symbol 'asprintf' failed: symbol not defined
ld: error: version script assignment of 'JL_LIBJULIA_1.11' to symbol 'rec_backtrace' failed: symbol not defined
ld: error: version script assignment of 'JL_LIBJULIA_1.11' to symbol 'localtime_r' failed: symbol not defined
ld: error: version script assignment of 'JL_LIBJULIA_1.11' to symbol 'restore_signals' failed: symbol not defined
ld: error: version script assignment of 'JL_LIBJULIA_1.11' to symbol 'add_library_mapping' failed: symbol not defined
ld: error: version script assignment of 'JL_LIBJULIA_1.11' to symbol 'jlbacktrace' failed: symbol not defined
ld: error: version script assignment of 'JL_LIBJULIA_1.11' to symbol 'jlbacktracet' failed: symbol not defined
ld: error: version script assignment of 'JL_LIBJULIA_1.11' to symbol '_IO_stdin_used' failed: symbol not defined
ld: error: version script assignment of 'JL_LIBJULIA_1.11' to symbol '_Z24jl_coverage_data_pointerN4llvm9StringRefEi' failed: symbol not defined
ld: error: version script assignment of 'JL_LIBJULIA_1.11' to symbol '_Z22jl_coverage_alloc_lineN4llvm9StringRefEi' failed: symbol not defined
ld: error: version script assignment of 'JL_LIBJULIA_1.11' to symbol '_Z22jl_malloc_data_pointerN4llvm9StringRefEi' failed: symbol not defined
ld: error: version script assignment of 'JL_LIBJULIA_1.11' to symbol 'llvmGetPassPluginInfo' failed: symbol not defined

🤔

ararslan · 2025-04-01T18:50:42Z

Issue with src/julia.expmap I guess? Maybe needs more/fewer entries?

Zentrik · 2025-04-02T09:46:56Z

I guess d269d7d isn't in 1.11

ararslan · 2025-04-02T20:44:07Z

ld: error: version script assignment of 'JL_LIBJULIA_1.11' to symbol 'arraylist_grow' failed: symbol not defined
ld: error: version script assignment of 'JL_LIBJULIA_1.11' to symbol 'small_arraylist_grow' failed: symbol not defined

Perhaps those should be either removed or amended to arraylist_grow* and small_arraylist_grow* in the version script?

Zentrik · 2025-04-02T22:36:35Z

Was done in 97ecdb8

giordano · 2025-04-10T10:04:14Z

Only test failure is on i686-linux-gnu:

Error in testset math:
Test Failed at /cache/build/tester-amdci4-10/julialang/julia-release-1-dot-11/julia-b387421113/share/julia/test/math.jl:1600
  Expression: Core.Compiler.is_foldable(effects)
     Context: effects = (+c,+e,+n,!t,+s,+m,+u,+o,+r)
              T = Float64

but that's happening also in #57714, so it's unrelated to this PR. I'm going to merge it.

(Cherry-picked from PR #57874)

This includes three commits that fix the version script for use with newer LLD. This has already been fixed on 1.11, 1.12, and master. Commits were cherry-picked from #55363, #57874, and #53633.

(Cherry-picked from PR #57874)

gbaraldi force-pushed the gb/1.11llvmnew branch from 3841e46 to 4c18f54 Compare March 24, 2025 15:22

ararslan mentioned this pull request Mar 24, 2025

Update FreeBSD image from 13.2 to 13.4 JuliaCI/sandboxed-buildkite-agent#95

Merged

KristofferC force-pushed the backports-release-1.11 branch 2 times, most recently from 5c74dc0 to 618c74e Compare March 31, 2025 19:26

giordano force-pushed the gb/1.11llvmnew branch from 4c18f54 to 81dd6d8 Compare April 1, 2025 18:07

giordano mentioned this pull request Apr 8, 2025

Build fails with clang: ld: error: version script assignment of 'JL_LIBJULIA_1.11' to symbol '__stack_chk_guard' failed: symbol not defined #58036

Closed

gbaraldi and others added 3 commits April 9, 2025 18:14

Add LLVM build with bfloat fix

77172eb

Also add lld checksums

c8b17eb

[src] Fix arraylist and small_arraylist symbols in expmap

b387421

giordano force-pushed the gb/1.11llvmnew branch from c6fbc4a to b387421 Compare April 9, 2025 17:14

giordano marked this pull request as ready for review April 10, 2025 10:02

giordano merged commit 8979836 into backports-release-1.11 Apr 10, 2025

giordano deleted the gb/1.11llvmnew branch April 10, 2025 10:04

ararslan pushed a commit that referenced this pull request Apr 15, 2025

[src] Fix arraylist and small_arraylist symbols in expmap

22183ef

(Cherry-picked from PR #57874)

ararslan mentioned this pull request Apr 15, 2025

[release-1.10] Backport version script fixes #58130

Merged

KristofferC pushed a commit that referenced this pull request Jul 3, 2025

[src] Fix arraylist and small_arraylist symbols in expmap

e107ca8

(Cherry-picked from PR #57874)

Uh oh!

Conversation

gbaraldi commented Mar 24, 2025

Uh oh!

KristofferC commented Mar 24, 2025

Uh oh!

giordano commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ararslan commented Mar 24, 2025

Uh oh!

giordano commented Mar 24, 2025

Uh oh!

gbaraldi commented Mar 24, 2025

Uh oh!

giordano commented Mar 24, 2025

Uh oh!

giordano commented Apr 1, 2025

Uh oh!

giordano commented Apr 1, 2025

Uh oh!

ararslan commented Apr 1, 2025

Uh oh!

Zentrik commented Apr 2, 2025

Uh oh!

ararslan commented Apr 2, 2025

Uh oh!

Zentrik commented Apr 2, 2025

Uh oh!

giordano commented Apr 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

giordano commented Mar 24, 2025 •

edited

Loading