Fix UndefRefError in get for abstract-typed ScopedValue (#34)#35
Merged
Conversation
When `isassigned` returned true because a scope contained the value (not because `has_default` was set), the old implementation still passed `val.default` as the fallback to `Base.get`. For abstract type parameters, this field is uninitialized when no default was provided, causing an `UndefRefError`. Fix by gating all access to `val.default` behind a `val.has_default` check, mirroring the upstream Julia implementation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
@iamed2 can you take this for a spin? |
|
Yes I'll try it out. Thank you for this fix! |
JamesWrigley
approved these changes
Apr 28, 2026
JamesWrigley
left a comment
JamesWrigley
left a comment
Member
There was a problem hiding this comment.
Sorry about that, I didn't think to check if get() needed updating 😬 LGTM!
|
Verified to take AWS.jl's tests from failing to passing on Julia 1.10.11! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getfor abstract-typed ScopedValue (UndevVarError from ScopedValues.get on abstract-typed ScopedValue due to isassigned change #34)Code reviewed manually by me, adopted from current Base by Claude.