fix: escape user-controlled values in console log calls (issue #165)#175
Open
JuliaKalder wants to merge 1 commit into
Open
fix: escape user-controlled values in console log calls (issue #165)#175JuliaKalder wants to merge 1 commit into
JuliaKalder wants to merge 1 commit into
Conversation
Fixes log injection (CWE-117) by passing user-controlled strings as separate JSON.stringify'd arguments instead of interpolating them into template literals in console.warn/error calls. Fixes #165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes log injection (CWE-117 / OWASP Log Injection) in
resolveNestedTemplatesand attachment error handling inmodules/template-insert.js.User-controlled strings (template identifier, template name, attachment filename) were interpolated directly into
console.warn/console.errortemplate literals, allowing newlines and control characters to forge fake log entries in the Thunderbird developer console.Changes
template-insert.js:179—identifiernow passed asJSON.stringify(identifier)separate argtemplate-insert.js:184—nestedTemplate.namenow passed asJSON.stringify(nestedTemplate.name)separate argtemplate-insert.js:358—att.namenow passed asJSON.stringify(att.name)separate argTesting
Fixes #165