Skip to content

Fix/remove self loops adjmat mutation #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarloLucibello merged 2 commits into from
Mar 29, 2026
Merged

Fix/remove self loops adjmat mutation #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd3e50f
Fix remove_self_loops mutation for adjacency graphs
Parvm1102 Mar 27, 2026
60ac2d7
Merge branch 'JuliaGraphs:master' into fix/remove-self-loops-adjmat-m…
Parvm1102 Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion GNNGraphs/src/transform.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ end

function remove_self_loops(g::GNNGraph{<:ADJMAT_T})
@assert isempty(g.edata)
A = g.graph
A = copy(g.graph)
A[diagind(A)] .= 0
if A isa AbstractSparseMatrix
dropzeros!(A)
Expand Down
14 changes: 14 additions & 0 deletions GNNGraphs/test/transform.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,20 @@ end
@test size(get_edge_weight(g2)) == (g2.num_edges,)
@test size(g2.edata.e1) == (3, g2.num_edges)
@test size(g2.edata.e2) == (g2.num_edges,)
else
A = [1 1 0
0 1 1
1 0 0]
A_no_loops = [0 1 0
0 0 1
1 0 0]
g = GNNGraph(A; graph_type = GRAPH_T)
g2 = remove_self_loops(g)

@test Matrix(adjacency_matrix(g)) == A
@test Matrix(adjacency_matrix(g2)) == A_no_loops
@test g2.num_edges == count(!iszero, A_no_loops)
@test g.graph !== g2.graph
end
end
end
Expand Down
Loading