Skip to content

fix: sample_nbrs without replacement #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarloLucibello merged 2 commits into from
Mar 21, 2026
Merged

fix: sample_nbrs without replacement #648

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e76ba83
fix: sample_nbrs without replacement
Parvm1102 Mar 15, 2026
5d66f74
Merge branch 'JuliaGraphs:master' into fix-neighborloader-sampling-wi…
Parvm1102 Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion GNNGraphs/src/sampling.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ function sample_nbrs(loader::NeighborLoader, node::Int, layer::Int)
return Int[]
else
num_samples = min(loader.num_neighbors[layer], length(neighbors)) # Limit to required samples for this layer
return rand(neighbors, num_samples) # Randomly sample neighbors
return StatsBase.sample(neighbors, num_samples; replace = false) # Randomly sample distinct neighbors
end
end

Expand Down
Loading