Skip to content

Add LineString constructor for AbstractVector #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asinghvi17 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add LineString constructor for AbstractVector #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/basic_types.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,11 @@ A LineString is a collection of points connected by line segments.
struct LineString{Dim, T<:Real} <: AbstractGeometry{Dim, T}
points::Vector{Point{Dim, T}}
end

function LineString(points::AbstractVector{Point{Dim, T}}) where {Dim, T}
return LineString{Dim,T}(convert(Vector{Point{Dim, T}}, points))
end

Base.length(ls::LineString) = length(coordinates(ls))
Base.:(==)(a::LineString, b::LineString) = a.points == b.points
coordinates(ls::LineString) = ls.points
Expand Down
23 changes: 23 additions & 0 deletions test/geointerface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,3 +129,26 @@ end
@test ext.Y == (0.0f0, 1.0f0)
@test ext.Z == (0.0f0, 1.0f0)
end

@testset "Convert from StaticArrays" begin
using GeometryBasics.StaticArrays

# LineString from StaticVector
ls = GeoInterface.convert(GeometryBasics, GeoInterface.LineString(SA[(1.0, 2.0), (3.0, 4.0)]))
@test ls isa LineString{2, Float64}
@test length(ls) == 2
@test ls.points[1] == Point(1.0, 2.0)
@test ls.points[2] == Point(3.0, 4.0)

# Polygon from StaticVector of StaticVector rings
ring = GeoInterface.LinearRing(SA[(0.0, 0.0), (1.0, 0.0), (1.0, 1.0), (0.0, 1.0), (0.0, 0.0)])
poly = GeoInterface.convert(GeometryBasics, GeoInterface.Polygon(SA[ring]))
@test poly isa Polygon{2, Float64}

# MultiLineString from StaticVector
line1 = GeoInterface.LineString(SA[(1.0, 2.0), (3.0, 4.0)])
line2 = GeoInterface.LineString(SA[(5.0, 6.0), (7.0, 8.0)])
mls = GeoInterface.convert(GeometryBasics, GeoInterface.MultiLineString([line1, line2]))
@test mls isa MultiLineString{2, Float64}
@test length(mls) == 2
end
Loading