Adding Crater to Volcano Topography

[aelligp]

When adding a crater to a volcano it adds an artificial kink in the topography compared to the plain cone shape without.

EDIT: add_volcano() is not in the tests

Without Crater:

With Crater of 0.5km:

Here is a MWE for this setup:

    Lx = Ly = 50
    x = range(0.0, Lx, nx);
    y = range(0.0, Ly, 2);
    z = range(-25.0, 5.0, nz);
    Grid = CartData(xyz_grid(x,y,z));

    Phases = fill(4, nx, 2, nz);

    Temp = fill(0.0, nx, 2, nz);

    add_box!(Phases, Temp, Grid;
        xlim=(minimum(Grid.x.val), maximum(Grid.x.val)),
        ylim=(minimum(Grid.y.val), maximum(Grid.y.val)),
        zlim=(minimum(Grid.z.val), 0.0),
        phase = LithosphericPhases(Layers=[30], Phases=[1]),
        T = HalfspaceCoolingTemp(Age=11)
    )

    add_volcano!(Phases, Temp, Grid;
    volcanic_phase  = 1,
    center          = (mean(Grid.x.val),  0.0),
    height          = 3,
    radius          = 5,
    # crater          = 0.5,
    base            = 0.0,
    background      = nothing,
    T               = HalfspaceCoolingTemp(Age=20)
    )

    add_ellipsoid!(Phases, Temp, Grid;
        cen    = (mean(Grid.x.val), 0,-5.0),
        axes   = (3.5, 2.5, 2.0),
        phase  = ConstantPhase(2),
        T      = ConstantTemp(T=1000)
    )
    add_sphere!(Phases, Temp, Grid;
    cen = (mean(Grid.x.val), 0,-5.0),
    radius = 0.5,
    phase  = ConstantPhase(3),
    T      = ConstantTemp(T=1100)
    )
    add_cylinder!(Phases, Temp, Grid;
    base = (mean(Grid.x.val), 0, -3.25),
    cap  = (mean(Grid.x.val), 0, 3.00),
    radius = 0.05,
    phase  = ConstantPhase(2),
    T      = ConstantTemp(T=1000),
    )

    Grid = addfield(Grid,(; Phases, Temp))


    li = (abs(last(x)-first(x)), abs(last(z)-first(z)))
    origin = (x[1], z[1])

    ph      = Phases[:,1,:]
    T       = Temp[:,1,:]
    # write_paraview(Grid, "Volcano2D")

[ArneSpang]

Just stumbled across this. I can imagine that the reason is as follows:
Adding the crater does not increase the radius, consequently, the flanks have to steepen. So there is no kink, it is just a matter of the resolution that makes it appear like a kink.