Skip to content

Test invalidation count? #262

Closed
Closed

Description

@adrhill

If possible, SCT should test its invalidation count in CI to avoid issues like #258 and #261.

Activity

  1. adrhill commented on Sep 10, 2025

    @adrhill
    CollaboratorAuthor
  2. nsajko commented on Sep 10, 2025

    @nsajko
    Contributor

    Another method addition in this package that causes invalidation is ifelse. Basically the same case as the other issues. Except, I suppose, you can't get rid of that method without breaking changes.

    Regarding testing the invalidation count, I vehemently support adding such tests to upstream (issue JuliaLang/julia#47022, PR JuliaLang/julia#57884), however it's tricky to test invalidations for a package. The issue is that invalidation depends on both:

    • What is loaded before starting to measure, which is the sysimage at the very least, perhaps also other packages.

    • The dependencies of your package, as they need to be loaded before your package can be loaded.

    So I suppose you would need to pin both the version of Julia, and of all your deps for the test that counts invalidations, which limits the usefulness of the test somewhat.

  3. linked a pull request that will close this issueTest Invalidations in CI #264on Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    InvalidationsMethod invalidations that should be fixed.testingImprove package tests

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions